Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

###The approach

The approach

###Error handling

Error handling

###Security

Security

###Usability

Usability

###The approach

###Error handling

###Security

###Usability

The approach

Error handling

Security

Usability

deleted 83 characters in body
Source Link
Your Common Sense
  • 9.1k
  • 1
  • 22
  • 51

it will let you to catch only this particular kind of exception, letting real errors to be handled elsewhere and indeed logged for the future inspection.:

whereas real errors have to be handled elsewhere, either in the dedicated handler or at least a global try catch around the entire application code as it makes no sense to write a repeated error_log call in every distinct chunk of code.

$extensions = ['jpg', 'jpeg', 'png', 'gif', 'html', 'txt', 'pdf', 'doc'];
foreach ($_FILES as $file) {
 $file_ext = strtolower(end(explode('.', $file['name'])));
 $destination = $path . $file['name'];
 ...
 move_uploaded_file($file['tmp_name]$file['tmp_name'], $destination);
}

it will let you to catch only this particular kind of exception, letting real errors to be handled elsewhere and indeed logged for the future inspection.

whereas real errors have to be handled elsewhere, either in the dedicated handler or at least a global try catch around the entire application as it makes no sense to write a repeated error_log call in every distinct chunk of code.

$extensions = ['jpg', 'jpeg', 'png', 'gif', 'html', 'txt', 'pdf', 'doc'];
foreach ($_FILES as $file) {
 $file_ext = strtolower(end(explode('.', $file['name'])));
 $destination = $path . $file['name'];
 ...
 move_uploaded_file($file['tmp_name], $destination);
}

it will let you to catch only this particular kind of exception:

whereas real errors have to be handled elsewhere, either in the dedicated handler or at least a global try catch around the entire application code as it makes no sense to write a repeated error_log call in every distinct chunk of code.

$extensions = ['jpg', 'jpeg', 'png', 'gif', 'html', 'txt', 'pdf', 'doc'];
foreach ($_FILES as $file) {
 $file_ext = strtolower(end(explode('.', $file['name'])));
 $destination = $path . $file['name'];
 ...
 move_uploaded_file($file['tmp_name'], $destination);
}
added 4 characters in body
Source Link
Your Common Sense
  • 9.1k
  • 1
  • 22
  • 51

I would also consider not using the original fienamesfilenames as they would create a real mess with all sorts of weird characters and possible overwrite each other. The simplest solution would be just md5()md5() from ththe file contents.

it will let you to handle them the most natural way using foreach, eliminating the need of count() call, a counter and even distinct variables to hold certain values from $_FILES array:

I would also consider not using the original fienames as they would create a real mess with all sorts of weird characters and possible overwrite each other. The simplest solution would be just md5() from th file contents.

it will let you to handle them the most natural way using foreach

I would also consider not using the original filenames as they would create a real mess with all sorts of weird characters and possible overwrite each other. The simplest solution would be just md5() from the file contents.

it will let you to handle them the most natural way using foreach, eliminating the need of count() call, a counter and even distinct variables to hold certain values from $_FILES array:

Source Link
Your Common Sense
  • 9.1k
  • 1
  • 22
  • 51
Loading
lang-php

AltStyle によって変換されたページ (->オリジナル) /