Skip to main content
Code Review

Return to Answer

replaced http://au1.php.net with https://www.php.net
Source Link

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.
replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.
Added reference to comment.
Source Link
Paul
  • 4k
  • 2
  • 22
  • 38

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings.
  • Personally I would use an if else rather than have two identical ternary conditions.

Use Prepared Statements

Your code is vulnerable to SQL injection attacks. Use PDO or mysqli prepared statements to avoid this. See this answer for how to use PDO for this. If you are using mysql_* you should know that it is already in the deprecation process.

Miscellaneous

  • Consider using empty to check for empty strings (see comment from Corbin below).
  • Personally I would use an if else rather than have two identical ternary conditions.
Source Link
Paul
  • 4k
  • 2
  • 22
  • 38
Loading
default

AltStyle によって変換されたページ (->オリジナル) /