Skip to main content
Code Review

Return to Answer

replaced https://vuejs.org/v2 with https://v2.vuejs.org/v2
Source Link
  • At the moment all your current hobbies only consists of a name. I think you could use a simple string instead of wrapping it in an object (for point 8 this is not possible though, of course).

  • No need to check if (!this.deleted) before setting this.deleted = true;

  • setStyle should be a computed property computed property

  • You can use @click instead of v-on:click, you can also use :style instead of v-bind:style (just syntactic sugar)

  • I would put the v-if="deleted" on the <div id="deleted-message"> instead of the inner <p> element.

  • At the moment all your current hobbies only consists of a name. I think you could use a simple string instead of wrapping it in an object (for point 8 this is not possible though, of course).

  • No need to check if (!this.deleted) before setting this.deleted = true;

  • setStyle should be a computed property

  • You can use @click instead of v-on:click, you can also use :style instead of v-bind:style (just syntactic sugar)

  • I would put the v-if="deleted" on the <div id="deleted-message"> instead of the inner <p> element.

  • At the moment all your current hobbies only consists of a name. I think you could use a simple string instead of wrapping it in an object (for point 8 this is not possible though, of course).

  • No need to check if (!this.deleted) before setting this.deleted = true;

  • setStyle should be a computed property

  • You can use @click instead of v-on:click, you can also use :style instead of v-bind:style (just syntactic sugar)

  • I would put the v-if="deleted" on the <div id="deleted-message"> instead of the inner <p> element.

Source Link
Simon Forsberg
  • 59.7k
  • 9
  • 157
  • 311
  • At the moment all your current hobbies only consists of a name. I think you could use a simple string instead of wrapping it in an object (for point 8 this is not possible though, of course).

  • No need to check if (!this.deleted) before setting this.deleted = true;

  • setStyle should be a computed property

  • You can use @click instead of v-on:click, you can also use :style instead of v-bind:style (just syntactic sugar)

  • I would put the v-if="deleted" on the <div id="deleted-message"> instead of the inner <p> element.

lang-js

AltStyle によって変換されたページ (->オリジナル) /