Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation
  • variable naming. Use descriptive variable names. Variable names like l, i or j are not meaningful and raise questions when reading the code

###Code Style

Code Style

###Performance

Performance

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation
  • variable naming. Use descriptive variable names. Variable names like l, i or j are not meaningful and raise questions when reading the code

###Code Style

###Performance

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation
  • variable naming. Use descriptive variable names. Variable names like l, i or j are not meaningful and raise questions when reading the code

Code Style

Performance

added 384 characters in body
Source Link
alecxe
  • 17.5k
  • 8
  • 52
  • 93

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation
  • variable naming. Use descriptive variable names. Variable names like l, i or j are not meaningful and raise questions when reading the code

###Code Style

###Performance

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation

###Code Style

###Performance

  • since you are requesting the pages from the same host multiple times, consider switching to requests making use of a single session instance which allows to re-use an underlying TCP connection making subsequent requests to the same host faster

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation
  • variable naming. Use descriptive variable names. Variable names like l, i or j are not meaningful and raise questions when reading the code

###Code Style

###Performance

Source Link
alecxe
  • 17.5k
  • 8
  • 52
  • 93

Some of the general things I would work on:

  • split the code into separate modules logically. Currently, you have all the code mixed up in single file - you have argument parsing, database interactions, web-scraping code blocks in one place
  • consistent indentation. Use 4 spaces for indentation

###Code Style

###Performance

  • since you are requesting the pages from the same host multiple times, consider switching to requests making use of a single session instance which allows to re-use an underlying TCP connection making subsequent requests to the same host faster
lang-py

AltStyle によって変換されたページ (->オリジナル) /