Timeline for Tidy up number counting code
Current License: CC BY-SA 3.0
8 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
May 23, 2017 at 12:40 | history | edited | Community Bot |
replaced http://stackoverflow.com/ with https://stackoverflow.com/
|
|
Nov 23, 2012 at 17:38 | comment | added | tb- | I promised to write a comment, so here we go. I will keep it short for limited space. SoC is a good thing, but I would use it carefully, not force it. Sometime, it is harder to understand code if it is divided across all the places. Using generics if you need only one case is not advised. Do not code for undefined future usage. I would keep the Random private & provide getter. Or do not provide it at all, because implementation is done in the subclass. The countPrinter approach looks rather fine. Overall, from my view it is a nice and clean approach. | |
Oct 30, 2012 at 17:37 | history | edited | Adam | CC BY-SA 3.0 |
used diamond notation where possible
|
Oct 29, 2012 at 22:12 | history | edited | Adam | CC BY-SA 3.0 |
added 21 characters in body
|
Oct 29, 2012 at 16:26 | comment | added | Adam | Thank you for the kind words. You may find this introduction to Java Collections helpful. There's also a Wikipedia article and an extensive tutorial (this page is the most helpful as an overview). | |
Oct 29, 2012 at 16:14 | comment | added | Andrew Martin | I think 'wow' is appropriate. I'll work my way through all your suggestions and amend my work appropriately - but it'll take me quite a while! I'm not at all familiar with things like HashMap, TreeMap or Array Lists. Thank you so much for taking the time to provide all of this. | |
Oct 29, 2012 at 15:17 | history | edited | Adam | CC BY-SA 3.0 |
added 35 characters in body
|
Oct 29, 2012 at 14:54 | history | answered | Adam | CC BY-SA 3.0 |