Timeline for A Simple Cluster Generator v0.3
Current License: CC BY-SA 3.0
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jun 10, 2020 at 13:24 | history | edited | Community Bot |
Commonmark migration
|
|
| Aug 17, 2017 at 0:36 | comment | added | Miller |
Gotcha - I was having trouble implementing this same thing on the vectors and ostreams, but it works with the unsigned int. I'm vastly reworking the code (again) with your suggestions and to get rid of reporting.
|
|
| Aug 17, 2017 at 0:36 | vote | accept | Miller | ||
| Aug 17, 2017 at 0:31 | comment | added | Justin |
@Miller I'm saying that if you have some type T, and you have a parameter const T parameter because you don't modify it in the body of the function, just remove the const in the header file, and have it there in the cpp file. The const is an implementation detail. I was referring to that one specific parameter. For example: coliru.stacked-crooked.com/a/8d828cd0dc709715
|
|
| Aug 17, 2017 at 0:20 | comment | added | Miller |
One more quick note, @Justin. I'm taking your "minor nitpick" above into account while recoding, but it doesn't let me compile. Am I understanding correctly: you were saying delete the consts in the .h file, but leave them only in the .cpp?
|
|
| Aug 16, 2017 at 21:08 | comment | added | Justin |
@Miller Passing a std::ostream& is more general. It makes for a better interface.
|
|
| Aug 16, 2017 at 21:05 | comment | added | Miller |
Thank you again, Justin! I'll work on this over the next few days - a quick note on the std::string vs. std::ostream argument: I was attempting to concisify the setup in main(). All the user has to do currently is pass a string (the filename) - it also appears to make opening, closing, and appending a file a little easier as this happens many times throughout the program. But if I'm hearing you correctly, passing an ostream is more standard?
|
|
| Aug 16, 2017 at 21:01 | vote | accept | Miller | ||
| Aug 16, 2017 at 21:09 | |||||
| Aug 16, 2017 at 20:50 | history | answered | Justin | CC BY-SA 3.0 |