concat.py

consts.py

map_imager.py

rosreestr.py

utils.py

views.py

mixins.py

concat.py

consts.py

map_imager.py

rosreestr.py

utils.py

views.py

mixins.py

I have wrote a django app that would get and some data to input and give you an image to output, image have 3 layers:

• google map image
• rosreestr(russian docs layer)
• data from geojson layer

I ever listen that I'm junior, pls help me fix it.
I think so hard find a job, sometime I wanna learn Erlang or Scala for find job more easy.

# -*- coding: utf-8 -*-
from django.http import HttpResponse
from django.views.generic import View

import json

from .map_imager import select_map_image, create_map_image, RosreestrImager
from .map_filler import MapFiller
from . import utils
from .concat import concat_images
from .mixins import respond_as_attachment


class PrintLayView(View):
 def get(self, request, *args, **kwargs):
 self.init_data(request)
 if self.include_rosreestr:
 self.create_rosreestr_image()
 try:
 self.create_map_image()
 except IOError:
 return HttpResponse('Произошла ошибка. Попробуй задать меньше "Максимальный размер плитки (тайла)"')
 self.create_lay_image()
 image_stream = concat_images(self.img, self.lay, self.img_rosreestr)
 return respond_as_attachment(request, image_stream)

 def init_data(self, request):
 self.img_rosreestr = None
 self.data = json.loads(request.GET['data'])
 self.valid_data()
 self.unpack_data()

 def valid_data(self):
 if 'layersProps' not in self.data:
 return HttpResponse('Data is not a valid, need `layersProps`')
 if 'mapName' not in self.data:
 return HttpResponse('Data is not a valid, need `mapName`')

 def unpack_data(self):
 self.layers_props = json.loads(self.data['layersProps'])
 self.upperleft = self.data['upperleft']
 self.lowerright = self.data['lowerright']
 self.detail_level = int(self.data['detailLevel'])
 self.zoom = int(self.data['zoom'])
 self.zoom += self.detail_level
 self.map_name = self.data['mapName']
 self.include_rosreestr = self.data['includeRosreestr']

 def create_rosreestr_image(self):
 rosreestr_imager = RosreestrImager(upperleft=self.upperleft,
 lowerright=self.lowerright,
 detail_level=self.detail_level,
 zoom=self.zoom)
 self.img_rosreestr = rosreestr_imager.init_image()

 def create_map_image(self):
 map_imager = select_map_image(self.map_name)
 self.imager = map_imager(upperleft=self.upperleft,
 lowerright=self.lowerright,
 zoom=self.zoom)
 self.img = self.imager.init_image()

 def create_lay_image(self):
 layers = map(utils.map_geom_data,
 self.layers_props)

 Map = MapFiller(self.imager)
 Map.filling_map(layers)
 Map.zoom_to_layers_box()
 self.lay = create_map_image(Map)

I have written a Django app that would get some input and give you an image as output. The output image has 3 layers:

• Google Map image
• rosreestr(russian docs layer)
• data from geojson layer

I hear that I write code like a junior developer, so please help me improve, especially regarding clear code and architecture. (I am also interested in learning Erlang or Scala.)

# -*- coding: utf-8 -*-
from django.http import HttpResponse
from django.views.generic import View
import json
from .map_imager import select_map_image, create_map_image, RosreestrImager
from .map_filler import MapFiller
from . import utils
from .concat import concat_images
from .mixins import respond_as_attachment
class PrintLayView(View):
 def get(self, request, *args, **kwargs):
 self.init_data(request)
 if self.include_rosreestr:
 self.create_rosreestr_image()
 try:
 self.create_map_image()
 except IOError:
 return HttpResponse('Произошла ошибка. Попробуй задать меньше "Максимальный размер плитки (тайла)"')
 self.create_lay_image()
 image_stream = concat_images(self.img, self.lay, self.img_rosreestr)
 return respond_as_attachment(request, image_stream)
 def init_data(self, request):
 self.img_rosreestr = None
 self.data = json.loads(request.GET['data'])
 self.valid_data()
 self.unpack_data()
 def valid_data(self):
 if 'layersProps' not in self.data:
 return HttpResponse('Data is not a valid, need `layersProps`')
 if 'mapName' not in self.data:
 return HttpResponse('Data is not a valid, need `mapName`')
 def unpack_data(self):
 self.layers_props = json.loads(self.data['layersProps'])
 self.upperleft = self.data['upperleft']
 self.lowerright = self.data['lowerright']
 self.detail_level = int(self.data['detailLevel'])
 self.zoom = int(self.data['zoom'])
 self.zoom += self.detail_level
 self.map_name = self.data['mapName']
 self.include_rosreestr = self.data['includeRosreestr']
 def create_rosreestr_image(self):
 rosreestr_imager = RosreestrImager(upperleft=self.upperleft,
 lowerright=self.lowerright,
 detail_level=self.detail_level,
 zoom=self.zoom)
 self.img_rosreestr = rosreestr_imager.init_image()
 def create_map_image(self):
 map_imager = select_map_image(self.map_name)
 self.imager = map_imager(upperleft=self.upperleft,
 lowerright=self.lowerright,
 zoom=self.zoom)
 self.img = self.imager.init_image()
 def create_lay_image(self):
 layers = map(utils.map_geom_data,
 self.layers_props)
 Map = MapFiller(self.imager)
 Map.filling_map(layers)
 Map.zoom_to_layers_box()
 self.lay = create_map_image(Map)

God day!
I have wrote a django app that would get and some data to input and give you an image to output, image have 3 layers:

• google map image
• rosreestr(russian docs layer)
• data from geojson layer
  I ever listen that I'm junior, pls help me fix it.
  I think so hard find a job, sometime I wanna learn Erlang or Scala for find job more easy.
  Thanks for your attention.
  

My repo with this project https://github.com/candyboober/printmap/tree/master/src

I have wrote a django app that would get and some data to input and give you an image to output, image have 3 layers:

• google map image
• rosreestr(russian docs layer)
• data from geojson layer

I ever listen that I'm junior, pls help me fix it.
I think so hard find a job, sometime I wanna learn Erlang or Scala for find job more easy.

Full code on GitHub