Return to Answer

Only a short answer about Style

• You should choose a coding style and after choosen you should stick to it. Right now you have mixed styles, e.g sometimes you are using braces {} for single statement for loops and sometimes you omit them.

I would like to encourage you to always use them because omitting braces can lead to hidden and therefor hard to track bugs.

• Commented code is dead code and should be removed. If you need to know such stuff you should use a code revision system like svn/git

• If you are using Java >= 7 you should use the diamond operator like so

   List<String> names = new ArrayList<>();
  

Only a short answer about Style

• You should choose a coding style and after choosen you should stick to it. Right now you have mixed styles, e.g sometimes you are using braces {} for single statement for loops and sometimes you omit them.

  I would like to encourage you to always use them because omitting braces can lead to hidden and therefor hard to track bugs.

• Commented code is dead code and should be removed. If you need to know such stuff you should use a code revision system like svn/git

• If you are using Java >= 7 you should use the diamond operator like so

   List<String> names = new ArrayList<>();
  

Only a short answer about Style

• You should choose a coding style and after choosen you should stick to it. Right now your have mixed styles, e.g sometimes you are using braces {} for single statement for loops and sometimes you omit them.

I would like to encourage you to always use them because omitting braces can lead to hidden and therefor hard to track bugs.

• Commented code is dead code and should be removed. If you need to know such stuff you should use a code revision system like svn/git

• If you are using Java >= 7 you should use the diamond operator like so

   List<String> names = new ArrayList<>();
  

Only a short answer about Style

• You should choose a coding style and after choosen you should stick to it. Right now you have mixed styles, e.g sometimes you are using braces {} for single statement for loops and sometimes you omit them.

I would like to encourage you to always use them because omitting braces can lead to hidden and therefor hard to track bugs.

• Commented code is dead code and should be removed. If you need to know such stuff you should use a code revision system like svn/git

• If you are using Java >= 7 you should use the diamond operator like so

   List<String> names = new ArrayList<>();