Skip to main content
Code Review

Return to Answer

added 272 characters in body
Source Link
t3chb0t
  • 44.6k
  • 9
  • 84
  • 190

There's not much to complain about. You've implemented all improvents so the performance is now very good. But hey! This is a good thing ;-)

What's left are just a few style things:

public static void RemoveAll<K, V>(this IDictionary<K, V> dict, Func<K, V, bool> match)

These K and V should be TKey and TValue.


var distinctProcesses = new Dictionary<string, Process>();
foreach (var filteredProcess in filteredProcesses)

You use vars. Not everywhere but finally somewhere :-D


[OrderBy.Ascending.ToString()]
[ShowOptions.Default.ToString()]

I'm not very fond of these ToStrings. Why not pure enums?


bInspect_Click

The code mixes the hungarian notation - this actually should be btnInspect_Click becasue b stands for bool - with the human notation:

ProcessTrackerIcon_MouseClick

and even mixed hungarian-human notation:

ComboBoxSorting_SelectedIndexChanged

preferable:

SortingComboBox_SelectedIndexChanged

if (cbEnableAutoUpdate.Checked)
{
 RefreshList();
}

This is not very pretty. The check-box should enable/disable the timer via its Enabled property and not prevent it from doint its job like that.

There's not much to complain about. You've implemented all improvents so the performance is now very good. But hey! This is a good thing ;-)

What's left are just a few style things:

public static void RemoveAll<K, V>(this IDictionary<K, V> dict, Func<K, V, bool> match)

These K and V should be TKey and TValue.


var distinctProcesses = new Dictionary<string, Process>();
foreach (var filteredProcess in filteredProcesses)

You use vars. Not everywhere but finally somewhere :-D


[OrderBy.Ascending.ToString()]
[ShowOptions.Default.ToString()]

I'm not very fond of these ToStrings. Why not pure enums?


bInspect_Click

The code mixes the hungarian notation - this actually should be btnInspect_Click becasue b stands for bool - with the human notation:

ProcessTrackerIcon_MouseClick

and even mixed hungarian-human notation:

ComboBoxSorting_SelectedIndexChanged

preferable:

SortingComboBox_SelectedIndexChanged

There's not much to complain about. You've implemented all improvents so the performance is now very good. But hey! This is a good thing ;-)

What's left are just a few style things:

public static void RemoveAll<K, V>(this IDictionary<K, V> dict, Func<K, V, bool> match)

These K and V should be TKey and TValue.


var distinctProcesses = new Dictionary<string, Process>();
foreach (var filteredProcess in filteredProcesses)

You use vars. Not everywhere but finally somewhere :-D


[OrderBy.Ascending.ToString()]
[ShowOptions.Default.ToString()]

I'm not very fond of these ToStrings. Why not pure enums?


bInspect_Click

The code mixes the hungarian notation - this actually should be btnInspect_Click becasue b stands for bool - with the human notation:

ProcessTrackerIcon_MouseClick

and even mixed hungarian-human notation:

ComboBoxSorting_SelectedIndexChanged

preferable:

SortingComboBox_SelectedIndexChanged

if (cbEnableAutoUpdate.Checked)
{
 RefreshList();
}

This is not very pretty. The check-box should enable/disable the timer via its Enabled property and not prevent it from doint its job like that.

Source Link
t3chb0t
  • 44.6k
  • 9
  • 84
  • 190

There's not much to complain about. You've implemented all improvents so the performance is now very good. But hey! This is a good thing ;-)

What's left are just a few style things:

public static void RemoveAll<K, V>(this IDictionary<K, V> dict, Func<K, V, bool> match)

These K and V should be TKey and TValue.


var distinctProcesses = new Dictionary<string, Process>();
foreach (var filteredProcess in filteredProcesses)

You use vars. Not everywhere but finally somewhere :-D


[OrderBy.Ascending.ToString()]
[ShowOptions.Default.ToString()]

I'm not very fond of these ToStrings. Why not pure enums?


bInspect_Click

The code mixes the hungarian notation - this actually should be btnInspect_Click becasue b stands for bool - with the human notation:

ProcessTrackerIcon_MouseClick

and even mixed hungarian-human notation:

ComboBoxSorting_SelectedIndexChanged

preferable:

SortingComboBox_SelectedIndexChanged
lang-cs

AltStyle によって変換されたページ (->オリジナル) /