Skip to main content
Code Review

Timeline for Simplified secure encryption of a String

Current License: CC BY-SA 3.0

32 events
when toggle format what by license comment
Nov 14, 2015 at 16:53 history edited Der Kommissar
edited tags
Jul 15, 2015 at 22:47 answer added Callabrator timeline score: 3
Jan 8, 2015 at 2:00 history edited jbtule CC BY-SA 3.0
added null check to string decrypt overloads
Nov 10, 2014 at 15:41 comment added aydjay /// <param name="secretMessage">The secret message.</param> /// <param name="password">The password.</param> etc... are horrible code smell and don't provide anything useful to your method summaries.
Nov 10, 2014 at 15:35 history edited Jamal CC BY-SA 3.0
deleted 561 characters in body
May 24, 2014 at 13:51 history edited Jamal CC BY-SA 3.0
deleted 22 characters in body; edited title
Nov 21, 2013 at 8:49 answer added ChrisWue timeline score: 0
Nov 18, 2013 at 13:26 answer added Jesse C. Slicer timeline score: 7
S Nov 18, 2013 at 1:06 history bounty ended Community Bot
S Nov 18, 2013 at 1:06 history notice removed Community Bot
S Nov 9, 2013 at 23:42 history bounty started Mike Edward Moras
S Nov 9, 2013 at 23:42 history notice added Mike Edward Moras Draw attention
Jul 16, 2013 at 15:32 comment added jbtule @SimonHughes This is here for peer review of best practices in security. But taking a quick peak, effortlessencryption could use some peer review too.
Jul 16, 2013 at 14:38 comment added Simon Hughes Take a look at the source code in effortlessencryption.codeplex.com Some of it may be of help
Jul 3, 2013 at 17:00 history edited jbtule CC BY-SA 3.0
added 2 characters in body
Jul 3, 2013 at 16:38 history edited jbtule CC BY-SA 3.0
added byte[] overloads; Post Made Community Wiki
Feb 27, 2013 at 1:24 history edited jbtule CC BY-SA 3.0
added random key generator helper, made constant time compare less variable
Jan 19, 2013 at 1:36 history edited jbtule CC BY-SA 3.0
Fixed Constant Time Comparison in AesThenHmac Removed Redundant Check in AESGCM Changed wireformat of AesThenHmac to be compatible with similar RNCryptor wireformat.
Jan 4, 2013 at 13:36 history edited jbtule CC BY-SA 3.0
Switch to a preconfigured key derivation iteration, for speed and security.
Jan 4, 2013 at 13:30 history edited jbtule CC BY-SA 3.0
Switch to a preconfigured key derivation iteration, for speed and security.
Dec 19, 2012 at 14:05 history edited jbtule CC BY-SA 3.0
added non-copyright notice
Oct 12, 2012 at 21:41 history edited Trevor Pilley
edited tags
Sep 13, 2012 at 22:04 review First posts
Sep 14, 2012 at 18:33
Aug 22, 2012 at 11:59 history tweeted twitter.com/#!/StackCodeReview/status/238244040682897408
Aug 21, 2012 at 18:00 history edited svick CC BY-SA 3.0
rm tag from title
Aug 21, 2012 at 15:16 history edited jbtule CC BY-SA 3.0
Added change for using IDisposable suggested by Jessie C S
Aug 21, 2012 at 15:01 comment added Jesse C. Slicer Looks snazzy. One more thing I just noticed: Rfc2898DeriveBytes inherits from a class which implements IDisposable in .NET 4 and beyond. So its use should be wrapped in a using block if you're targeting that version of the framework. .NET 2 (and 3.0/3.5), don't worry about it.
Aug 21, 2012 at 14:53 history edited jbtule CC BY-SA 3.0
Fixed formatting issue
Aug 21, 2012 at 14:15 comment added Jesse C. Slicer As far as best practices go, I see a few offhand: 1. static public XXX is idiomatically written as public static XXX. 2. Since all your methods are static, the class should be made static as well to prevent (useless) instances from being created. 3. Are your bit size numbers near the top of the classes intended to be modified? If so, make them private and have public properties to access them. If not, make them const.
Aug 21, 2012 at 13:59 history edited jbtule CC BY-SA 3.0
added 3 characters in body
Aug 21, 2012 at 13:09 history edited jbtule CC BY-SA 3.0
deleted 2 characters in body
Aug 21, 2012 at 12:54 history asked jbtule CC BY-SA 3.0
toggle format

AltStyle によって変換されたページ (->オリジナル) /