Return to Question

I want to optimize the below code, I have asked a similar question here. I know this approach is better than my last code but I feel there are ways to optimize this too.This code is used in almost every project and I am not satisfied with this answer. There are not even using last filter results and traversing whole list every time.

I want to optimize the below code, I have asked a similar question here. I know this approach is better than my last code but I feel there are ways to optimize this too.This code is used in almost every project and I am not satisfied with this answer. There are not even using last filter results and traversing whole list every time.

I want to optimize the below code, I have asked a similar question here. I know this approach is better than my last code but I feel there are ways to optimize this too.This code is used in almost every project and I am not satisfied with this answer. There are not even using last filter results and traversing whole list every time.

I want to optimize the below code, I have asked a similar question here. I know this approach is better than my last code but I feel there are ways to optimize this too.This code is used in almost every project and I am not satisfied with this answer. There are not even using last filter results and traversing whole list every time.

class MyFilter extends Filter {
 /**
 * 1. check do we have search results available (check map has this key)
 * 2. if available, remove all rows and add only those which are value for that key (string)
 * 3. else check do we have any key available starting like this, s=har, already available -ha then it can be reused
 *
 * @param constraint
 */
 @Override
 protected FilterResults performFiltering(CharSequence constraint) {
 //Here you have to implement filtering way
 final FilterResults results = new FilterResults();
 if (!mSearchMap.containsKey(constraint.toString())) {
 String supersetKey = getSupersetIfAvailable(mSearchMap, constraint.toString());
 if (supersetKey == null) {
 List<Integer> foundPositions = doFullSearch(copyList, constraint.toString());
 mSearchMap.put(constraint.toString(), foundPositions);
 } else {
 List<Integer> foundPositions = filterFromSuperset(copyList, mSearchMap.get(supersetKey), constraint.toString());
 mSearchMap.put(constraint.toString(), foundPositions);
 }
 }
 return results;
 }
 private String getSupersetIfAvailable(Map<String, List<Integer>> mSearchMap, String s) {
 Set<String> set = mSearchMap.keySet();
 List<String> list = new ArrayList<>(set);
 Collections.sort(list);
 Collections.reverse(list);
 for (String c : list) {
 if (s.startsWith(c.toString())) {
 return c;
 }
 }
 return null;
 }
 private List<Integer> filterFromSuperset(List<WeekWorkBean> list, List<Integer> supersetResults, String s) {
 List<Integer> results = new ArrayList<>();
 String lowerS = s.toLowerCase();
 for (int i = 0; i < supersetResults.size(); i++) {
 if (list.get(supersetResults.get(i)).getEmpName().toLowerCase().startsWith(lowerS)) {
 results.add(supersetResults.get(i));
 }
 }
 return results;
 }
 private List<Integer> doFullSearch(List<WeekWorkBean> list, String s) {
 List<Integer> results = new ArrayList<>();
 for (int i = 0; i < list.size(); i++) {
 if (list.get(i).getEmpName().toLowerCase().startsWith(s.toLowerCase())) {
 results.add(i);
 }
 }
 return results;
 }
 @Override
 protected void publishResults(CharSequence constraint, FilterResults results) {
 // here you can use result - (f.e. set in in adapter list)
 mList.clear();
 notifyDataSetChanged();
 List<Integer> res = mSearchMap.get(constraint.toString());
 int j = 0;
 for (Integer i : res) {
 mList.add(copyList.get(i));
 notifyItemInserted(j++);
 }
 }
 }

Edited code after answer

 @Override
 protected FilterResults performFiltering(CharSequence constraint) {
 final FilterResults results = new FilterResults();
 String strConstraint=constraint.toString();
 if (!mSearchMap.containsKey(constraint.toString())) {
 String supersetKey = getSupersetIfAvailable(mSearchMap, strConstraint);
 List<Integer> foundPositions;
 if (supersetKey == null) {
 foundPositions = doFullSearch(copyList, strConstraint);
 } else {
 foundPositions = filterFromSuperset(copyList, mSearchMap.get(supersetKey), strConstraint);
  }
 }
 mSearchMap.put(strConstraint, foundPositions);
 return results;
 }

class MyFilter extends Filter {
 /**
 * 1. check do we have search results available (check map has this key)
 * 2. if available, remove all rows and add only those which are value for that key (string)
 * 3. else check do we have any key available starting like this, s=har, already available -ha then it can be reused
 *
 * @param constraint
 */
 @Override
 protected FilterResults performFiltering(CharSequence constraint) {
 //Here you have to implement filtering way
 final FilterResults results = new FilterResults();
 if (!mSearchMap.containsKey(constraint.toString())) {
 String supersetKey = getSupersetIfAvailable(mSearchMap, constraint.toString());
 if (supersetKey == null) {
 List<Integer> foundPositions = doFullSearch(copyList, constraint.toString());
 mSearchMap.put(constraint.toString(), foundPositions);
 } else {
 List<Integer> foundPositions = filterFromSuperset(copyList, mSearchMap.get(supersetKey), constraint.toString());
 mSearchMap.put(constraint.toString(), foundPositions);
 }
 }
 return results;
 }
 private String getSupersetIfAvailable(Map<String, List<Integer>> mSearchMap, String s) {
 Set<String> set = mSearchMap.keySet();
 List<String> list = new ArrayList<>(set);
 Collections.sort(list);
 Collections.reverse(list);
 for (String c : list) {
 if (s.startsWith(c.toString())) {
 return c;
 }
 }
 return null;
 }
 private List<Integer> filterFromSuperset(List<WeekWorkBean> list, List<Integer> supersetResults, String s) {
 List<Integer> results = new ArrayList<>();
 String lowerS = s.toLowerCase();
 for (int i = 0; i < supersetResults.size(); i++) {
 if (list.get(supersetResults.get(i)).getEmpName().toLowerCase().startsWith(lowerS)) {
 results.add(supersetResults.get(i));
 }
 }
 return results;
 }
 private List<Integer> doFullSearch(List<WeekWorkBean> list, String s) {
 List<Integer> results = new ArrayList<>();
 for (int i = 0; i < list.size(); i++) {
 if (list.get(i).getEmpName().toLowerCase().startsWith(s.toLowerCase())) {
 results.add(i);
 }
 }
 return results;
 }
 @Override
 protected void publishResults(CharSequence constraint, FilterResults results) {
 // here you can use result - (f.e. set in in adapter list)
 mList.clear();
 notifyDataSetChanged();
 List<Integer> res = mSearchMap.get(constraint.toString());
 int j = 0;
 for (Integer i : res) {
 mList.add(copyList.get(i));
 notifyItemInserted(j++);
 }
 }
 }