This is an addition to other reviews.
###Validity of html
Validity of html
The following snippet is invalid. You must move this under the body tag. Keep in mind that a <h4> element is a level below <h3>. Even if your html page is properly parsed, semantic parsers will not understand the structure of the document. In fact "Welcome to (the) profile page" is not a title at all. Consider using a properly styled <header> perhaps.
<html class="no-js">
<h4> Welcome to profile page</h4>
<head>
The a tag in the following snippet can not occur in the head. Furthermore you have a duplicate title tag.
<title><?php echo $row['email']; ?></title>
<a href="user.php?<?php print($userRow['name']); ?>"></a> <title> <?php echo $row['name']; ?> Profile page </title>
You forget to close the head tag in the following snippet.
<!-- HTML5 shim, for IE6-8 support of HTML5 elements -->
<!--[if lt IE 9]>
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->
<body>
You are echoing variables directly, while they may contain invalid characters. This can produce invalid output. Instead, encode html entities for your chosen doctype, in this case html 5.
Odd html parts
###Odd html parts II see you use the following html several times.
<a href="profile1.php">
<button class="pedit" name="submit">Edit</button>
</a>
It makes little sense to use a button inside an <a> tag. Users do not expect a navigation event when clicking a button. Furthermore, since the buttons appear near a form, the user might expect the button to belong to that form. Just use a plain "Edit" text instead.
Classes
###Classes
YouYou are giving <h3> tags the class "h3". This is counter-productive. Either rename the class if you mean to style a specific group of h3 elements and name the class after what they have in common, or remove the class and style the elements with:
h3 {
color: pink;
}
This is an addition to other reviews.
###Validity of html
The following snippet is invalid. You must move this under the body tag. Keep in mind that a <h4> element is a level below <h3>. Even if your html page is properly parsed, semantic parsers will not understand the structure of the document. In fact "Welcome to (the) profile page" is not a title at all. Consider using a properly styled <header> perhaps.
<html class="no-js">
<h4> Welcome to profile page</h4>
<head>
The a tag in the following snippet can not occur in the head. Furthermore you have a duplicate title tag.
<title><?php echo $row['email']; ?></title>
<a href="user.php?<?php print($userRow['name']); ?>"></a> <title> <?php echo $row['name']; ?> Profile page </title>
You forget to close the head tag in the following snippet.
<!-- HTML5 shim, for IE6-8 support of HTML5 elements -->
<!--[if lt IE 9]>
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->
<body>
You are echoing variables directly, while they may contain invalid characters. This can produce invalid output. Instead, encode html entities for your chosen doctype, in this case html 5.
###Odd html parts I see you use the following html several times.
<a href="profile1.php">
<button class="pedit" name="submit">Edit</button>
</a>
It makes little sense to use a button inside an <a> tag. Users do not expect a navigation event when clicking a button. Furthermore, since the buttons appear near a form, the user might expect the button to belong to that form. Just use a plain "Edit" text instead.
###Classes
You are giving <h3> tags the class "h3". This is counter-productive. Either rename the class if you mean to style a specific group of h3 elements and name the class after what they have in common, or remove the class and style the elements with:
h3 {
color: pink;
}
This is an addition to other reviews.
Validity of html
The following snippet is invalid. You must move this under the body tag. Keep in mind that a <h4> element is a level below <h3>. Even if your html page is properly parsed, semantic parsers will not understand the structure of the document. In fact "Welcome to (the) profile page" is not a title at all. Consider using a properly styled <header> perhaps.
<html class="no-js">
<h4> Welcome to profile page</h4>
<head>
The a tag in the following snippet can not occur in the head. Furthermore you have a duplicate title tag.
<title><?php echo $row['email']; ?></title>
<a href="user.php?<?php print($userRow['name']); ?>"></a> <title> <?php echo $row['name']; ?> Profile page </title>
You forget to close the head tag in the following snippet.
<!-- HTML5 shim, for IE6-8 support of HTML5 elements -->
<!--[if lt IE 9]>
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->
<body>
You are echoing variables directly, while they may contain invalid characters. This can produce invalid output. Instead, encode html entities for your chosen doctype, in this case html 5.
Odd html parts
I see you use the following html several times.
<a href="profile1.php">
<button class="pedit" name="submit">Edit</button>
</a>
It makes little sense to use a button inside an <a> tag. Users do not expect a navigation event when clicking a button. Furthermore, since the buttons appear near a form, the user might expect the button to belong to that form. Just use a plain "Edit" text instead.
Classes
You are giving <h3> tags the class "h3". This is counter-productive. Either rename the class if you mean to style a specific group of h3 elements and name the class after what they have in common, or remove the class and style the elements with:
h3 {
color: pink;
}
This is an addition to other reviews.
###Validity of html
The following snippet is invalid. You must move this under the body tag. Keep in mind that a <h4> element is a level below <h3>. Even if your html page is properly parsed, semantic parsers will not understand the structure of the document. In fact "Welcome to (the) profile page" is not a title at all. Consider using a properly styled <header> perhaps.
<html class="no-js">
<h4> Welcome to profile page</h4>
<head>
The a tag in the following snippet can not occur in the head. Furthermore you have a duplicate title tag.
<title><?php echo $row['email']; ?></title>
<a href="user.php?<?php print($userRow['name']); ?>"></a> <title> <?php echo $row['name']; ?> Profile page </title>
You forget to close the head tag in the following snippet.
<!-- HTML5 shim, for IE6-8 support of HTML5 elements -->
<!--[if lt IE 9]>
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->
<body>
You are echoing variables directly, while they may contain invalid characters. This can produce invalid output. Instead, encode html entities for your chosen doctype, in this case html 5.
###Odd html parts I see you use the following html several times.
<a href="profile1.php">
<button class="pedit" name="submit">Edit</button>
</a>
It makes little sense to use a button inside an <a> tag. Users do not expect a navigation event when clicking a button. Furthermore, since the buttons appear near a form, the user might expect the button to belong to that form. Just use a plain "Edit" text instead.
###Classes
You are giving <h3> tags the class "h3". This is counter-productive. Either rename the class if you mean to style a specific group of h3 elements and name the class after what they have in common, or remove the class and style the elements with:
h3 {
color: pink;
}