Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

Reply for the edit:

Nice to see that the macrodef works :-). A few other ideas:

  1.  <attribute name="basename" default="unknown" />
    

Are you sure that you need the default attribute here? The macrodef documentation says the following:

The attributes will be required attributes unless a default value has been set.

  1. I'd create a list for

     <srcfiles file="@{basename}.dtx" />
     <srcfiles file="@{basename}.ins" />
    

Here is an example: Ant: using Filelist as Fileset in Uptodate? Ant: using Filelist as Fileset in Uptodate?

  1. After this I guess the three uptodate tag could be replaced with only one which uses a composite or a chained mapper but I'm not too familiar with these.

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

Reply for the edit:

Nice to see that the macrodef works :-). A few other ideas:

  1.  <attribute name="basename" default="unknown" />
    

Are you sure that you need the default attribute here? The macrodef documentation says the following:

The attributes will be required attributes unless a default value has been set.

  1. I'd create a list for

     <srcfiles file="@{basename}.dtx" />
     <srcfiles file="@{basename}.ins" />
    

Here is an example: Ant: using Filelist as Fileset in Uptodate?

  1. After this I guess the three uptodate tag could be replaced with only one which uses a composite or a chained mapper but I'm not too familiar with these.

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

Reply for the edit:

Nice to see that the macrodef works :-). A few other ideas:

  1.  <attribute name="basename" default="unknown" />
    

Are you sure that you need the default attribute here? The macrodef documentation says the following:

The attributes will be required attributes unless a default value has been set.

  1. I'd create a list for

     <srcfiles file="@{basename}.dtx" />
     <srcfiles file="@{basename}.ins" />
    

Here is an example: Ant: using Filelist as Fileset in Uptodate?

  1. After this I guess the three uptodate tag could be replaced with only one which uses a composite or a chained mapper but I'm not too familiar with these.
added 772 characters in body
Source Link
palacsint
  • 30.4k
  • 9
  • 82
  • 157

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

Reply for the edit:

Nice to see that the macrodef works :-). A few other ideas:

  1.  <attribute name="basename" default="unknown" />
    

Are you sure that you need the default attribute here? The macrodef documentation says the following:

The attributes will be required attributes unless a default value has been set.

  1. I'd create a list for

     <srcfiles file="@{basename}.dtx" />
     <srcfiles file="@{basename}.ins" />
    

Here is an example: Ant: using Filelist as Fileset in Uptodate?

  1. After this I guess the three uptodate tag could be replaced with only one which uses a composite or a chained mapper but I'm not too familiar with these.

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

Reply for the edit:

Nice to see that the macrodef works :-). A few other ideas:

  1.  <attribute name="basename" default="unknown" />
    

Are you sure that you need the default attribute here? The macrodef documentation says the following:

The attributes will be required attributes unless a default value has been set.

  1. I'd create a list for

     <srcfiles file="@{basename}.dtx" />
     <srcfiles file="@{basename}.ins" />
    

Here is an example: Ant: using Filelist as Fileset in Uptodate?

  1. After this I guess the three uptodate tag could be replaced with only one which uses a composite or a chained mapper but I'm not too familiar with these.
Source Link
palacsint
  • 30.4k
  • 9
  • 82
  • 157

The bar and foo targets (as well as the conditions on foo.uptodate and bar.uptodate) seems really similar to each other. I'd try to remove this duplication with a presetdef or a macrodef

lang-java

AltStyle によって変換されたページ (->オリジナル) /