Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link
if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.


private void parsePackage (String pack) {
 String name = pack.substring(pack.indexOf(".")+1,pack.length());
 char[] array = pack.toCharArray();
 int prev=0;
 for(int i=0,n=pack.length() ; i<n ; i++) {
 String temp="";
 if(i==n-1) {
 temp = pack.substring(prev,i+1);
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 else if(pack.charAt(i) == '.') {
 temp = pack.substring(prev,i);
 prev = i+1;
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 if(enabledActions.get(temp) != null) {
 Log.d("printout", "Package grabbed is: "+temp+" With Value: "+enabledActions.get(temp));
 }
 }
}

Rather than using a complex loop here, you could make use of String.split, then iterate over the String array afterwards. As String.split takes a regex, you'll want to escape the delimiter:

(Escape method taken from How can I use "." as the delimiter with String.split() in java How can I use "." as the delimiter with String.split() in java)

String[] packageNames = pack.split(Pattern.quote("."));
if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.


private void parsePackage (String pack) {
 String name = pack.substring(pack.indexOf(".")+1,pack.length());
 char[] array = pack.toCharArray();
 int prev=0;
 for(int i=0,n=pack.length() ; i<n ; i++) {
 String temp="";
 if(i==n-1) {
 temp = pack.substring(prev,i+1);
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 else if(pack.charAt(i) == '.') {
 temp = pack.substring(prev,i);
 prev = i+1;
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 if(enabledActions.get(temp) != null) {
 Log.d("printout", "Package grabbed is: "+temp+" With Value: "+enabledActions.get(temp));
 }
 }
}

Rather than using a complex loop here, you could make use of String.split, then iterate over the String array afterwards. As String.split takes a regex, you'll want to escape the delimiter:

(Escape method taken from How can I use "." as the delimiter with String.split() in java)

String[] packageNames = pack.split(Pattern.quote("."));
if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.


private void parsePackage (String pack) {
 String name = pack.substring(pack.indexOf(".")+1,pack.length());
 char[] array = pack.toCharArray();
 int prev=0;
 for(int i=0,n=pack.length() ; i<n ; i++) {
 String temp="";
 if(i==n-1) {
 temp = pack.substring(prev,i+1);
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 else if(pack.charAt(i) == '.') {
 temp = pack.substring(prev,i);
 prev = i+1;
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 if(enabledActions.get(temp) != null) {
 Log.d("printout", "Package grabbed is: "+temp+" With Value: "+enabledActions.get(temp));
 }
 }
}

Rather than using a complex loop here, you could make use of String.split, then iterate over the String array afterwards. As String.split takes a regex, you'll want to escape the delimiter:

(Escape method taken from How can I use "." as the delimiter with String.split() in java)

String[] packageNames = pack.split(Pattern.quote("."));
added 91 characters in body
Source Link
Pimgd
  • 22.5k
  • 5
  • 68
  • 144
if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.


private void parsePackage (String pack) {
 String name = pack.substring(pack.indexOf(".")+1,pack.length());
 char[] array = pack.toCharArray();
 int prev=0;
 for(int i=0,n=pack.length() ; i<n ; i++) {
 String temp="";
 if(i==n-1) {
 temp = pack.substring(prev,i+1);
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 else if(pack.charAt(i) == '.') {
 temp = pack.substring(prev,i);
 prev = i+1;
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 if(enabledActions.get(temp) != null) {
 Log.d("printout", "Package grabbed is: "+temp+" With Value: "+enabledActions.get(temp));
 }
 }
}

Rather than using a complex loop here, you could make use of String.split , then iterate over the String array afterwards. As String.split takes a regex, you'll want to escape the delimiter:

(Escape method taken from How can I use "." as the delimiter with String.split() in java )

String[] packageNames = pack.split(Pattern.quote("."));
if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.

if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.


private void parsePackage (String pack) {
 String name = pack.substring(pack.indexOf(".")+1,pack.length());
 char[] array = pack.toCharArray();
 int prev=0;
 for(int i=0,n=pack.length() ; i<n ; i++) {
 String temp="";
 if(i==n-1) {
 temp = pack.substring(prev,i+1);
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 else if(pack.charAt(i) == '.') {
 temp = pack.substring(prev,i);
 prev = i+1;
 Log.d("seetothis", "Name: " + temp +" has value= " + enabledActions.get(temp) );
 }
 if(enabledActions.get(temp) != null) {
 Log.d("printout", "Package grabbed is: "+temp+" With Value: "+enabledActions.get(temp));
 }
 }
}

Rather than using a complex loop here, you could make use of String.split , then iterate over the String array afterwards. As String.split takes a regex, you'll want to escape the delimiter:

(Escape method taken from How can I use "." as the delimiter with String.split() in java )

String[] packageNames = pack.split(Pattern.quote("."));
Better formatting
Source Link
syb0rg
  • 21.9k
  • 10
  • 113
  • 192
if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use !packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads") here.this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.

if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use !packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads") here. Explicit equality checks with false seem out of place.

if(packagename.equals(selfname)==false && packagename.equals("com.android.providers.downloads")==false) {
 Toast.makeText(this, "Package: "+packagename,Toast.LENGTH_LONG).show();
}

You can use this check instead:

!packagename.equals(selfname) && !packagename.equals("com.android.providers.downloads")

Explicit equality checks with false seem out of place.

Source Link
Pimgd
  • 22.5k
  • 5
  • 68
  • 144
Loading
lang-java

AltStyle によって変換されたページ (->オリジナル) /