Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

just to make your code similar, you could do this

function selectionSort(inputArray){
 var minNum;
 for( var i = 0; i <= inputArray.length-1; i++)
 {
 minNum = i;
 for( var j = i+1; j < inputArray.length; j++)
 {
 if(inputArray[j] < inputArray[minNum])
 {
 minNum = j;
 }
 }
 if(minNum != i ) {
 [inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
 }
 return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
 var minNum;
 for( var i = 0; i <= inputArray.length-1; i++)
 {
 minNum = i;
 for( var j = i+1; j < inputArray.length; j++)
 {
 if(inputArray[j] < inputArray[minNum])
 {
 minNum = j;
 }
 }
 if(minNum != i ) {
 [inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
 }
 return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
 var minNum;
 for( var i = 0; i <= inputArray.length-1; i++)
 {
 minNum = i;
 for( var j = i+1; j < inputArray.length; j++)
 {
 if(inputArray[j] < inputArray[minNum])
 {
 minNum = j;
 }
 }
 if(minNum != i ) {
 [inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
 }
 return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
var minNum;
for( var i = 0; i <= inputArray.length-1; i++)
{
 minNum = i;
 for( var j = i+1; j < inputArray.length; j++)
 {
 {
 if(inputArray[j] < inputArray[minNum])
 {
  {
 minNum = j;
 }
 }
 }
 if(minNum != i ){
 [inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
}
return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
var minNum;
for( var i = 0; i <= inputArray.length-1; i++)
{
 minNum = i;
 for( var j = i+1; j < inputArray.length; j++)
 
 {
 if(inputArray[j] < inputArray[minNum])
 {
  minNum = j;
 }
 
 }
 if(minNum != i ){
 [inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
}
return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
var minNum;
for( var i = 0; i <= inputArray.length-1; i++)
{
 minNum = i;
 for( var j = i+1; j < inputArray.length; j++)
 {
 if(inputArray[j] < inputArray[minNum])
 {
 minNum = j;
 }
 }
 if(minNum != i ){
 [inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
}
return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

indenting
Source Link
Tolani
  • 2.5k
  • 7
  • 31
  • 49

just to make your code similar, you could do this

function selectionSort(inputArray){
var minNum;
for( var i = 0; i <= inputArray.length-1; i++)
{
 minNum = i;

for( var j = i+1; j < inputArray.length; j++)

{
 if(inputArray[j] < inputArray[minNum])
 {

 minNum = j;
 }

}
if(minNum != i ){

[inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
} }
}
return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));
 // alert('['+selectionSort([1,31,26,4,3,12]) +']');

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
var minNum;
for( var i = 0; i <= inputArray.length-1; i++)
{
 minNum = i;
for( var j = i+1; j < inputArray.length; j++)
{
 if(inputArray[j] < inputArray[minNum])
 {
 minNum = j;
 }
}
if(minNum != i ){
[inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
} 
}
return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));
 // alert('['+selectionSort([1,31,26,4,3,12]) +']');

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

just to make your code similar, you could do this

function selectionSort(inputArray){
var minNum;
for( var i = 0; i <= inputArray.length-1; i++)
{
 minNum = i;

for( var j = i+1; j < inputArray.length; j++)

{
 if(inputArray[j] < inputArray[minNum])
 {

 minNum = j;
 }

}
if(minNum != i ){

[inputArray[i], inputArray[minNum]] = [inputArray[minNum], inputArray[i]];
 }
}
return inputArray;
}
console.log(selectionSort([1,31,26,4,3,12]));

Rather than declaring those variables swapElementIndex, shouldSwap temp minNum you only need to declare minNum. Also swapping items requires additional variables, I used ECMAScript How to swap two variables in javascript- ECMAScript e.g [a, b] = [b, a]; to swap the items

Source Link
Tolani
  • 2.5k
  • 7
  • 31
  • 49
Loading
default

AltStyle によって変換されたページ (->オリジナル) /