Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

So, let's look at the regex code itself. If you are going to be using PHP, I would recommend first looking into extended/verbose regex mode extended/verbose regex mode. This will allow you to document the expression in your code, so that the maintainer of it (which includes you 6 months in the future) will know what it is doing.

So, let's look at the regex code itself. If you are going to be using PHP, I would recommend first looking into extended/verbose regex mode. This will allow you to document the expression in your code, so that the maintainer of it (which includes you 6 months in the future) will know what it is doing.

So, let's look at the regex code itself. If you are going to be using PHP, I would recommend first looking into extended/verbose regex mode. This will allow you to document the expression in your code, so that the maintainer of it (which includes you 6 months in the future) will know what it is doing.

deleted 7 characters in body
Source Link
Phrancis
  • 20.5k
  • 6
  • 69
  • 155

As you can clearly see, the moment you stop taking into account the second field 204 for filtering, your regex matches almost everythingeverything. This can be problematic in a few ways:

As you can clearly see, the moment you stop taking into account the second field 204 for filtering, your regex matches almost everything. This can be problematic in a few ways:

As you can clearly see, the moment you stop taking into account the second field 204 for filtering, your regex matches everything. This can be problematic in a few ways:

added 1 character in body
Source Link
Phrancis
  • 20.5k
  • 6
  • 69
  • 155

The other matching groups arereallyare really just "match anything, even nothing" groups and there's only so much about them that could be improved, unless you inspect your data set very closely to look for patterns or tendencies.

The other matching groups arereally just "match anything, even nothing" groups and there's only so much about them that could be improved, unless you inspect your data set very closely to look for patterns or tendencies.


The other matching groups are really just "match anything, even nothing" groups and there's only so much about them that could be improved, unless you inspect your data set very closely to look for patterns or tendencies.

edited body
Source Link
Phrancis
  • 20.5k
  • 6
  • 69
  • 155
Loading
added 190 characters in body
Source Link
Phrancis
  • 20.5k
  • 6
  • 69
  • 155
Loading
Source Link
Phrancis
  • 20.5k
  • 6
  • 69
  • 155
Loading
default

AltStyle によって変換されたページ (->オリジナル) /