Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/

edited May 23, 2017 at 12:40

edited May 23, 2017 at 12:40

I didn't check everything yet but here are already some remarks:

Your example lacks the include of <string> so it doesn't compile this way.
Pretty obviously a copy and paste problem ;-)
Use the same types in for loops.
Currently you are comparing int i against the size_t return value of string::size().

e.g. for (int i = 0; i < letters.size(); ++i) should be for (size_t i = 0; i < letters.size(); ++i)

This might not look like a big deal but it will prevent you from unwanted or undefined behaviour unwanted or undefined behaviour.
The last parameter of getLetterCombos could be passed as const reference instead of copying the value on every call.

I didn't check everything yet but here are already some remarks:

Your example lacks the include of <string> so it doesn't compile this way.
Pretty obviously a copy and paste problem ;-)
Use the same types in for loops.
Currently you are comparing int i against the size_t return value of string::size().

e.g. for (int i = 0; i < letters.size(); ++i) should be for (size_t i = 0; i < letters.size(); ++i)

This might not look like a big deal but it will prevent you from unwanted or undefined behaviour.
The last parameter of getLetterCombos could be passed as const reference instead of copying the value on every call.

I didn't check everything yet but here are already some remarks:

Your example lacks the include of <string> so it doesn't compile this way.
Pretty obviously a copy and paste problem ;-)
Use the same types in for loops.
Currently you are comparing int i against the size_t return value of string::size().

e.g. for (int i = 0; i < letters.size(); ++i) should be for (size_t i = 0; i < letters.size(); ++i)

This might not look like a big deal but it will prevent you from unwanted or undefined behaviour.
The last parameter of getLetterCombos could be passed as const reference instead of copying the value on every call.

answered Mar 17, 2016 at 17:12

answered Mar 17, 2016 at 17:12

I didn't check everything yet but here are already some remarks:

Your example lacks the include of <string> so it doesn't compile this way.
Pretty obviously a copy and paste problem ;-)
Use the same types in for loops.
Currently you are comparing int i against the size_t return value of string::size().

e.g. for (int i = 0; i < letters.size(); ++i) should be for (size_t i = 0; i < letters.size(); ++i)

This might not look like a big deal but it will prevent you from unwanted or undefined behaviour.
The last parameter of getLetterCombos could be passed as const reference instead of copying the value on every call.

lang-cpp