Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link
if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.


if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.


if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.


added 1 character in body
Source Link
Quill
  • 12k
  • 5
  • 41
  • 93
if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.

This isn't bad, but it could be, if you don't know what it does.


if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.

if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.


Source Link
Quill
  • 12k
  • 5
  • 41
  • 93
if (window.cordova && window.cordova.plugins && window.cordova.plugins.Keyboard) {
 cordova.plugins.Keyboard.hideKeyboardAccessoryBar(true);
 cordova.plugins.Keyboard.disableScroll(true);
 }

Ionic has this feature builtin, and even has a plugin written specifically to make this process smoother and more reliable. I even wrote an answer on SO about it.


Your states look good, but your formatting is a little broken. You swap between four and two space indentation and some lines are completely wrong. I suggest using a cleaner, inbuilt in your IDE (like Atom's beautify), or online (like JSFiddle's tidy), but a cleaner would be good.

 .state('tab.attendee-detail',{
 url: '/attendee/:attendeeId',
 views: {
 'tab-event':{
 templateUrl: 'views/attendee.html',
 controller: 'AttendeeDetailCtrl',
 resolve: {
 attendee : function(AttendeeService) {
 return AttendeeService;
 }
 }
 }
 },
 params:{
 eventId: null,
 attendeeId: null,
 attending: true
 }
 })

The fact that you swap between two and four space indentation during your states makes me think you copy-pasted them in and just changed the values.

This isn't bad, but it could be, if you don't know what it does.

default

AltStyle によって変換されたページ (->オリジナル) /