Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

##Huge Point: Not escaping means not useful

Huge Point: Not escaping means not useful

##Big Point: Write real tests

Big Point: Write real tests

##Mid Point: Inconsistent constructors

Mid Point: Inconsistent constructors

##Mid Point: Needless interface

Mid Point: Needless interface

##Mid Point: Needless constants

Mid Point: Needless constants

##Minor Point: Whitespace

Minor Point: Whitespace

##Huge Point: Not escaping means not useful

##Big Point: Write real tests

##Mid Point: Inconsistent constructors

##Mid Point: Needless interface

##Mid Point: Needless constants

##Minor Point: Whitespace

Huge Point: Not escaping means not useful

Big Point: Write real tests

Mid Point: Inconsistent constructors

Mid Point: Needless interface

Mid Point: Needless constants

Minor Point: Whitespace

mention the TAB constant too
Source Link
AD7six
  • 1.4k
  • 9
  • 11

Huge Point: Not escaping means not useful ##Huge Point: Not escaping means not useful

Big Point: Write real tests ##Big Point: Write real tests

Mid Point: Inconsistent constructors ##Mid Point: Inconsistent constructors

Mid Point: Needless interface ##Mid Point: Needless interface

Mid Point: Needless constants ##Mid Point: Needless constants

Minor Point: Whitespace There's also this:

const TAB = " ";

Which is in fact set to four spaces. "\t" is easier and shorter to type.

##Minor Point: Whitespace

Huge Point: Not escaping means not useful

Big Point: Write real tests

Mid Point: Inconsistent constructors

Mid Point: Needless interface

Mid Point: Needless constants

Minor Point: Whitespace

##Huge Point: Not escaping means not useful

##Big Point: Write real tests

##Mid Point: Inconsistent constructors

##Mid Point: Needless interface

##Mid Point: Needless constants

There's also this:

const TAB = " ";

Which is in fact set to four spaces. "\t" is easier and shorter to type.

##Minor Point: Whitespace

wording
Source Link
AD7six
  • 1.4k
  • 9
  • 11

It's more to type and doesn't add any clarity, I therefore suggest they aren't of any value.

It's more to type and doesn't add any clarity, I therefore suggest they aren't of any value.

It's more to type and doesn't add any clarity.

update constructor exmaple
Source Link
AD7six
  • 1.4k
  • 9
  • 11
Loading
whitespace point correction
Source Link
AD7six
  • 1.4k
  • 9
  • 11
Loading
added 6 characters in body
Source Link
AD7six
  • 1.4k
  • 9
  • 11
Loading
deleted 34 characters in body; added 186 characters in body; deleted 55 characters in body
Source Link
AD7six
  • 1.4k
  • 9
  • 11
Loading
correct security warning
Source Link
AD7six
  • 1.4k
  • 9
  • 11
Loading
Source Link
AD7six
  • 1.4k
  • 9
  • 11
Loading
lang-php

AltStyle によって変換されたページ (->オリジナル) /