###Dead code
Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
Errors not useful
###Errors not useful YouYou could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
Errors not useful
You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong.
As it is, this will return an error but no useful data as to what was input that cause the error. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong.
As it is, this will return an error but no useful data as to what was input that cause the error. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
###Dead code
In this:
COMMIT TRANSACTION select null END TRY
This line of code: select null does nothing useful (read: nothing at all) and should be deleted. I have no idea why it is there to begin with, but querying for NULL with no criteria will always be null.
###Errors not useful You could improve this error reporting:
ELSE RAISERROR('Required parameters are not provided or Required parameters are passed as NULL',13,1)
Why? As it is, this is raising an error with no information on "why" the error was raised. At the very least return the input parameters so the user/dev can decipher what is wrong. This is especially relevant if you are logging those errors somewhere.
You would want to include as much relevant information as possible in your errors, especially if there are multiple instances and databases involved. There are few things which hinder improvement and bug fixes more than half-arsed error logs. Log everything and let the developers sort it out.
TLDR: Don't filter error logs, just store stuff. Developers can filter them easily if they need to.