Skip to main content
Code Review

Return to Question

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

This is a follow up to this question this question.

This is a follow up to this question.

This is a follow up to this question.

added 4 characters in body
Source Link
Jamal
  • 35.2k
  • 13
  • 134
  • 238

This is a follow up to this question .

I'd appreciate help with a few more things. They are after all the code (for a better context).

ShingekinoKyojinOVA-01(480p)[Hatsuyuki-Kaitou][D8E8CC75].mkv -- Expected Category "Shingeki no Kyojin"
(Hi10)_Gosick_-_22_The_Christmas_Carol_Adorns_the_Happiness_by_the_Window_(BD_720p)_(Broken).mkv -- Expected Category "Gosick"
Manyuu.Hiken-chou.04.HD.BD.Kira.ACB.mkv -- Expected Category "Manyu Hiken-cho"
Commie_Steins Gate 01 Prologue to the Beginning and End.mkv -- Expected Category "Steins Gate"
Commie_Steins_Gate_02_BD_720p_AnimeKens.com.mkv -- Expected Category "Steins Gate"
ShingekinoKyojinOVA-01(480p)[Hatsuyuki-Kaitou][D8E8CC75].mkv -- Expected Category "Shingeki no Kyojin"
(Hi10)_Gosick_-_22_The_Christmas_Carol_Adorns_the_Happiness_by_the_Window_(BD_720p)_(Broken).mkv
-- Expected Category "Gosick"
Manyuu.Hiken-chou.04.HD.BD.Kira.ACB.mkv -- Expected Category "Manyu Hiken-cho"
Commie_Steins Gate 01 Prologue to the Beginning and End.mkv -- Expected Category "Steins Gate"
Commie_Steins_Gate_02_BD_720p_AnimeKens.com.mkv -- Expected Category "Steins Gate"

Extract from the Sourcesource XML Filefile:

<report>
 <args>
 <type>anime</type>
 <name></name>
 <search></search>
 </args>
 <item>
 <id>17938</id>
 <gid>721551383</gid>
 <type>ONA</type>
 <name>Koyomimonogatari</name>
 <precision>ONA</precision>
 <vintage>2016年01月09日</vintage>
 </item>
 <item>
 <id>17937</id>
 <gid>1319318627</gid>
 <type>TV</type>
 <name>Qualidea Code</name>
 <precision>TV</precision>
 </item>
</report>
<report>
 <args>
 <type>anime</type>
 <name></name>
 <search></search>
 </args>
 <item>
 <id>17938</id>
 <gid>721551383</gid>
 <type>ONA</type>
 <name>Koyomimonogatari</name>
 <precision>ONA</precision>
 <vintage>2016年01月09日</vintage>
 </item>
 <item>
 <id>17937</id>
 <gid>1319318627</gid>
 <type>TV</type>
 <name>Qualidea Code</name>
 <precision>TV</precision>
 </item>
</report>

NOTENote:

  • I'm using the WPF Open Dialog 1.1.1 NuGet package by

    I'm using the WPF Open Dialog 1.1.1 NuGet package by Christoph Gattnar for handling the folder-selection operation.

    Christoph Gattnar for handling the folder-selection operation.
  • I've added a default manifest file to require Administrator Access when the app runs, this avoids UnauthorizedAccessException. The following piece of code was added into the manifest file to make this happen
  • <requestedExecutionLevel level="requireAdministrator" uiAccess="false" />

    I've added a default manifest file to require Administrator Access when the app runs, this avoids UnauthorizedAccessException. The following piece of code was added into the manifest file to make this happen:

     <requestedExecutionLevel level="requireAdministrator" uiAccess="false" />
    

ISSUESIssues:

  1. How can I check matches with the directory name but only do this once for all the files existing in that directory? There are many ways to do it, but which is the most scalable and efficient?
  2. Will it be faster to pre-compile the RegexRegex pattern for all the 3000~ title-names during LoadXML? Because otherwise the same title is being matched at least twice. Will it be faster than the currently implemented Intersect method?

More code refactoring is always welcome :)

Thank you for your time

This is a follow up to this question

I'd appreciate help with a few more things. They are after all the code (for a better context)

ShingekinoKyojinOVA-01(480p)[Hatsuyuki-Kaitou][D8E8CC75].mkv -- Expected Category "Shingeki no Kyojin"
(Hi10)_Gosick_-_22_The_Christmas_Carol_Adorns_the_Happiness_by_the_Window_(BD_720p)_(Broken).mkv -- Expected Category "Gosick"
Manyuu.Hiken-chou.04.HD.BD.Kira.ACB.mkv -- Expected Category "Manyu Hiken-cho"
Commie_Steins Gate 01 Prologue to the Beginning and End.mkv -- Expected Category "Steins Gate"
Commie_Steins_Gate_02_BD_720p_AnimeKens.com.mkv -- Expected Category "Steins Gate"

Extract from the Source XML File:

<report>
 <args>
 <type>anime</type>
 <name></name>
 <search></search>
 </args>
 <item>
 <id>17938</id>
 <gid>721551383</gid>
 <type>ONA</type>
 <name>Koyomimonogatari</name>
 <precision>ONA</precision>
 <vintage>2016年01月09日</vintage>
 </item>
 <item>
 <id>17937</id>
 <gid>1319318627</gid>
 <type>TV</type>
 <name>Qualidea Code</name>
 <precision>TV</precision>
 </item>
</report>

NOTE:

  • I'm using the WPF Open Dialog 1.1.1 NuGet package by Christoph Gattnar for handling the folder-selection operation.
  • I've added a default manifest file to require Administrator Access when the app runs, this avoids UnauthorizedAccessException. The following piece of code was added into the manifest file to make this happen
  • <requestedExecutionLevel level="requireAdministrator" uiAccess="false" />

ISSUES:

  1. How can I check matches with the directory name but only do this once for all the files existing in that directory? There are many ways to do it, but which is the most scalable and efficient?
  2. Will it be faster to pre-compile the Regex pattern for all the 3000~ title-names during LoadXML? Because otherwise the same title is being matched at least twice. Will it be faster than the currently implemented Intersect method?

More code refactoring is always welcome :)

Thank you for your time

This is a follow up to this question .

I'd appreciate help with a few more things. They are after all the code (for a better context).

ShingekinoKyojinOVA-01(480p)[Hatsuyuki-Kaitou][D8E8CC75].mkv -- Expected Category "Shingeki no Kyojin"
(Hi10)_Gosick_-_22_The_Christmas_Carol_Adorns_the_Happiness_by_the_Window_(BD_720p)_(Broken).mkv
-- Expected Category "Gosick"
Manyuu.Hiken-chou.04.HD.BD.Kira.ACB.mkv -- Expected Category "Manyu Hiken-cho"
Commie_Steins Gate 01 Prologue to the Beginning and End.mkv -- Expected Category "Steins Gate"
Commie_Steins_Gate_02_BD_720p_AnimeKens.com.mkv -- Expected Category "Steins Gate"

Extract from the source XML file:

<report>
 <args>
 <type>anime</type>
 <name></name>
 <search></search>
 </args>
 <item>
 <id>17938</id>
 <gid>721551383</gid>
 <type>ONA</type>
 <name>Koyomimonogatari</name>
 <precision>ONA</precision>
 <vintage>2016年01月09日</vintage>
 </item>
 <item>
 <id>17937</id>
 <gid>1319318627</gid>
 <type>TV</type>
 <name>Qualidea Code</name>
 <precision>TV</precision>
 </item>
</report>

Note:

  • I'm using the WPF Open Dialog 1.1.1 NuGet package by Christoph Gattnar for handling the folder-selection operation.

  • I've added a default manifest file to require Administrator Access when the app runs, this avoids UnauthorizedAccessException. The following piece of code was added into the manifest file to make this happen:

     <requestedExecutionLevel level="requireAdministrator" uiAccess="false" />
    

Issues:

  1. How can I check matches with the directory name but only do this once for all the files existing in that directory? There are many ways to do it, but which is the most scalable and efficient?
  2. Will it be faster to pre-compile the Regex pattern for all the 3000~ title-names during LoadXML? Because otherwise the same title is being matched at least twice. Will it be faster than the currently implemented Intersect method?
Added link to Github
Source Link
Paras
  • 585
  • 3
  • 18

Github Repository:

You can find the project files here

NOTE:

NOTE:

Github Repository:

You can find the project files here

NOTE:

Source Link
Paras
  • 585
  • 3
  • 18
Loading
default

AltStyle によって変換されたページ (->オリジナル) /