Return to Answer

databasePath, databaseFile, databaseBaseURL, databaseVersionURL` should be constants (all uppercase with words separated by underscores):

private static final String DATABASE_PATH = "/data/data/com.sandbox.databaseone/databases/"; private static final String DATABASE_FILE = "dbone.sqlite"; private static final String DATABASE_BASE_URL = "http://www.redstalker.com/dbone/"; private static final String DATABASE_VERSION_URL = "version.txt";

According to the previous Code Conventions, init_database should be initDatabase.

If databaseBaseURL and databaseVersionURL hadn't be constant I'd named them as databaseBaseUrl and databaseBaseVersionUrl. From Effective Java, 2nd edition, Item 56: Adhere to generally accepted naming conventions:

While uppercase may be more common, a strong argument can made in favor of capitalizing only the first letter: even if multiple acronyms occur back-to-back, you can still tell where one word starts and the next word ends. Which class name would you rather see, HTTPURL or HttpUrl?

 public DatabaseManager()
 {
 database = null;
 }

Close your streams in a finally block. In case of a previous errors they won't be closed.

The code does databasePath + databaseFile more than once. Create a method for that.

I don't know if it is applicable to Android or not, but in Java it's a good practice to pass the character set to the constructor of InputStreamReader. Without this InputStreamReader uses the default charset which could vary from system to system.

 BufferedReader reader = new BufferedReader(new InputStreamReader(in, "UTF-8"));

I'd use Commons IO's IOUtils for the copying. It has a copy(InputStream input, OutputStream output) which you could use in the DownloadDatabase task and you could use copy(InputStream input, Writer output) in the DatabaseVersionCheck task if you replace the StringBuilder to a StringWriter.

In the DatabaseVersionCheck.onPostExecute I'd use guard clauses:

 @Override
 protected void onPostExecute(String result) {
 if(result == null) {
 return;
 }
 int version = Integer.parseInt(result);
 if(version <= currentVersion) {
 return;
 }
 nextVersion = version;
 DownloadDatabase d = new DownloadDatabase();
 d.execute();
 }

databasePath, databaseFile, databaseBaseURL, databaseVersionURL should be constants (all uppercase with words separated by underscores):

 private static final String DATABASE_PATH = 
 "/data/data/com.sandbox.databaseone/databases/";
 private static final String DATABASE_FILE = "dbone.sqlite";
 private static final String DATABASE_BASE_URL = 
 "http://www.redstalker.com/dbone/";
 private static final String DATABASE_VERSION_URL =
 "version.txt";

According to the previous Code Conventions, init_database should be initDatabase.

If databaseBaseURL and databaseVersionURL hadn't be constant I'd named them as databaseBaseUrl and databaseBaseVersionUrl. From Effective Java, 2nd edition, Item 56: Adhere to generally accepted naming conventions:

While uppercase may be more common, a strong argument can made in favor of capitalizing only the first letter: even if multiple acronyms occur back-to-back, you can still tell where one word starts and the next word ends. Which class name would you rather see, HTTPURL or HttpUrl?

 public DatabaseManager()
 {
 database = null;
 }

Close your streams in a finally block. In case of a previous errors they won't be closed.

The code does databasePath + databaseFile more than once. Create a method for that.

I don't know if it is applicable to Android or not, but in Java it's a good practice to pass the character set to the constructor of InputStreamReader. Without this InputStreamReader uses the default charset which could vary from system to system.

 BufferedReader reader = new BufferedReader(new InputStreamReader(in, "UTF-8"));

I'd use Commons IO's IOUtils for the copying. It has a copy(InputStream input, OutputStream output) which you could use in the DownloadDatabase task and you could use copy(InputStream input, Writer output) in the DatabaseVersionCheck task if you replace the StringBuilder to a StringWriter.

In the DatabaseVersionCheck.onPostExecute I'd use guard clauses:

 @Override
 protected void onPostExecute(String result) {
 if(result == null) {
 return;
 }
 int version = Integer.parseInt(result);
 if(version <= currentVersion) {
 return;
 }
 nextVersion = version;
 DownloadDatabase d = new DownloadDatabase();
 d.execute();
 }