What's wrong in my models.py Bank account model implementation in django project?Django
What's wrong in my models.py in django project?
There is a draft of my models.py. What can I do for code quality and readability increase?
from datetime import timedelta
from django.contrib.auth.models import User
from django.db import models
from django.utils import timezone
class Rule(models.Model):
start_date = models.DateField()
end_date = models.DateField()
deposit_percent = models.FloatField()
credit_percent = models.FloatField()
@staticmethod
def on_date(_date):
return Rule.objects.get(start_date__lte=_date, end_date__gte=_date)
class BankAccount(models.Model):
LEGAL = 1
NATURAL = 2
DEBET = 1
CREDIT = 2
owner_type = models.PositiveSmallIntegerField(choices=(
(LEGAL, 'Физическое лицо'),
(NATURAL, 'Юридическое лицо'),
))
method = models.PositiveSmallIntegerField(choices=(
(DEBET, 'Дебет'),
(CREDIT, 'Кредит'),
))
name = models.CharField(max_length=254)
owner = models.ForeignKey(User, related_name='w_accounts')
spectators = models.ManyToManyField(User, related_name='r_accounts')
when_opened = models.DateField()
@property
def balance(self):
assert self.method == self.DEBET
today = timezone.now()
rule = Rule.on_date(self.when_opened)
result = 0
current_date = self.when_opened
while current_date <= today:
result -= sum(x.total for x in self.cashing_set.on_date(current_date))
result -= sum(x.total for x in self.outcome_transfers.on_date(current_date))
result += sum(x.total for x in self.deposit_set.on_date(current_date))
result += sum(x.total for x in self.income_transfers.on_date(current_date))
result *= 1 + rule.deposit_percent * 0.01
current_date += timedelta(days=1)
return result
@property
def debt(self):
assert self.method == self.CREDIT
today = timezone.now()
rule = Rule.on_date(self.when_opened)
result = 0
current_date = self.when_opened
while current_date <= today:
result += sum(x.total for x in self.cashing_set.on_date(current_date))
result += sum(x.total for x in self.outcome_transfers.on_date(current_date))
result -= sum(x.total for x in self.deposit_set.on_date(current_date))
result -= sum(x.total for x in self.income_transfers.on_date(current_date))
result *= 1 + rule.credit_percent
current_date += timedelta(days=1)
return result
class OperationManager(models.Manager):
def on_date(self, date):
return (super(OperationManager, self).get_queryset()).filter(when__gte=date, when__lte=date)
class MoneyTransfer(models.Model):
sender = models.ForeignKey(BankAccount, related_name='outcome_transfers')
receiver = models.ForeignKey(BankAccount, related_name='income_transfers')
when = models.DateTimeField()
total = models.FloatField()
comment = models.CharField(max_length=255)
objects = OperationManager()
class Deposit(models.Model):
account = models.ForeignKey(BankAccount)
total = models.FloatField()
banker = models.ForeignKey(User)
when = models.DateTimeField()
objects = OperationManager()
class Cashing(models.Model):
account = models.ForeignKey(BankAccount)
total = models.FloatField()
banker = models.ForeignKey(User)
when = models.DateTimeField()
objects = OperationManager()
lang-py