Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

That's not really how you're supposed to use internals and this variables.

Consider using the prototype chain instead.


#self:

self:

Using self the way you did is literally pointless. I don't know whether you're a Python dev and that feels familiar, but that's wrong.


#jQuery:

jQuery:

You use jQuery for document.ready, $(selector) and .append, I would recommend removing it. Using a library of jQuery's size for those three functions is just pointless when you can use polyfills from vanilla JavaScript.

That's not really how you're supposed to use internals and this variables.

Consider using the prototype chain instead.


#self:

Using self the way you did is literally pointless. I don't know whether you're a Python dev and that feels familiar, but that's wrong.


#jQuery:

You use jQuery for document.ready, $(selector) and .append, I would recommend removing it. Using a library of jQuery's size for those three functions is just pointless when you can use polyfills from vanilla JavaScript.

That's not really how you're supposed to use internals and this variables.

Consider using the prototype chain instead.


self:

Using self the way you did is literally pointless. I don't know whether you're a Python dev and that feels familiar, but that's wrong.


jQuery:

You use jQuery for document.ready, $(selector) and .append, I would recommend removing it. Using a library of jQuery's size for those three functions is just pointless when you can use polyfills from vanilla JavaScript.

Source Link
Quill
  • 12k
  • 5
  • 41
  • 93

That's not really how you're supposed to use internals and this variables.

Consider using the prototype chain instead.


#self:

Using self the way you did is literally pointless. I don't know whether you're a Python dev and that feels familiar, but that's wrong.


#jQuery:

You use jQuery for document.ready, $(selector) and .append, I would recommend removing it. Using a library of jQuery's size for those three functions is just pointless when you can use polyfills from vanilla JavaScript.

default

AltStyle によって変換されたページ (->オリジナル) /