Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link
  • You have different indention styles for methods. Sometimes you are using [K&R][1]K&R and sometimes you are using [Allman][2]Allman style.
  • sometimes you are using underscore prefixed method variables (which isn't the preffered way) and sometimes you use camelCase casing to name your method variables.
  • sometimes you are using braces {} for single instruction else or for each and sometimes you don't use them.

Based on the [NET naming guidelines][3]NET naming guidelines methods should be made out of verbs or verb phrases. You have a lot of methods which aren't following this guidelines like UserList, Message, Seen, UserTimeout and many more.

you should either use [string.Format()][4]string.Format() like so

is not good. [1]: https://en.wikipedia.org/wiki/Indent_style#K.26R_style [2]: https://en.wikipedia.org/wiki/Indent_style#Allman_style [3]: http://msdn.microsoft.com/en-us/library/ms229002.aspx [4]: https://msdn.microsoft.com/en-us/library/system.string.format%28v=vs.110%29.aspx

  • You have different indention styles for methods. Sometimes you are using [K&R][1] and sometimes you are using [Allman][2] style.
  • sometimes you are using underscore prefixed method variables (which isn't the preffered way) and sometimes you use camelCase casing to name your method variables.
  • sometimes you are using braces {} for single instruction else or for each and sometimes you don't use them.

Based on the [NET naming guidelines][3] methods should be made out of verbs or verb phrases. You have a lot of methods which aren't following this guidelines like UserList, Message, Seen, UserTimeout and many more.

you should either use [string.Format()][4] like so

is not good. [1]: https://en.wikipedia.org/wiki/Indent_style#K.26R_style [2]: https://en.wikipedia.org/wiki/Indent_style#Allman_style [3]: http://msdn.microsoft.com/en-us/library/ms229002.aspx [4]: https://msdn.microsoft.com/en-us/library/system.string.format%28v=vs.110%29.aspx

  • You have different indention styles for methods. Sometimes you are using K&R and sometimes you are using Allman style.
  • sometimes you are using underscore prefixed method variables (which isn't the preffered way) and sometimes you use camelCase casing to name your method variables.
  • sometimes you are using braces {} for single instruction else or for each and sometimes you don't use them.

Based on the NET naming guidelines methods should be made out of verbs or verb phrases. You have a lot of methods which aren't following this guidelines like UserList, Message, Seen, UserTimeout and many more.

you should either use string.Format() like so

is not good.

Bounty Awarded with 200 reputation awarded by RubberDuck
added 323 characters in body
Source Link
Heslacher
  • 50.9k
  • 5
  • 83
  • 177
  • You have different indention styles for methods. Sometimes you are using K&R [K&R][1] and sometimes you are using Allman [Allman][2] style.
  • sometimes you are using underscore prefixed method variables (which isn't the preffered way) and sometimes you use camelCase casing to name your method variables.
  • sometimes you are using braces {} for single instruction else or for each and sometimes you don't use them.

Based on the NET naming guidelines [NET naming guidelines][3] methods should be made out of verbs or verb phrases. You have a lot of methods which aren't following this guidelines like UserList, Message, Seen, UserTimeout and many more.

you should either use string.Format() [string.Format()][4] like so


Parents should talk to their children by using methods and properties but a child should talk to its parent by using events. So this

case "shutdown":
 if (access > 1)
 {
 SendMessage("Goodybe.");
 Eve.Run = false; // <- this
 }

is not good. [1]: https://en.wikipedia.org/wiki/Indent_style#K.26R_style [2]: https://en.wikipedia.org/wiki/Indent_style#Allman_style [3]: http://msdn.microsoft.com/en-us/library/ms229002.aspx [4]: https://msdn.microsoft.com/en-us/library/system.string.format%28v=vs.110%29.aspx

  • You have different indention styles for methods. Sometimes you are using K&R and sometimes you are using Allman style.
  • sometimes you are using underscore prefixed method variables (which isn't the preffered way) and sometimes you use camelCase casing to name your method variables.
  • sometimes you are using braces {} for single instruction else or for each and sometimes you don't use them.

Based on the NET naming guidelines methods should be made out of verbs or verb phrases. You have a lot of methods which aren't following this guidelines like UserList, Message, Seen, UserTimeout and many more.

you should either use string.Format() like so

  • You have different indention styles for methods. Sometimes you are using [K&R][1] and sometimes you are using [Allman][2] style.
  • sometimes you are using underscore prefixed method variables (which isn't the preffered way) and sometimes you use camelCase casing to name your method variables.
  • sometimes you are using braces {} for single instruction else or for each and sometimes you don't use them.

Based on the [NET naming guidelines][3] methods should be made out of verbs or verb phrases. You have a lot of methods which aren't following this guidelines like UserList, Message, Seen, UserTimeout and many more.

you should either use [string.Format()][4] like so


Parents should talk to their children by using methods and properties but a child should talk to its parent by using events. So this

case "shutdown":
 if (access > 1)
 {
 SendMessage("Goodybe.");
 Eve.Run = false; // <- this
 }

is not good. [1]: https://en.wikipedia.org/wiki/Indent_style#K.26R_style [2]: https://en.wikipedia.org/wiki/Indent_style#Allman_style [3]: http://msdn.microsoft.com/en-us/library/ms229002.aspx [4]: https://msdn.microsoft.com/en-us/library/system.string.format%28v=vs.110%29.aspx

added 403 characters in body
Source Link
Heslacher
  • 50.9k
  • 5
  • 83
  • 177

Declaring multiple variables on the "same line" like in the ChannelMessage class doesn't buy you anything but costs readability.

internal class ChannelMessage
{
 public DateTime Time;
 public string
 Nickname,
 Realname,
 Hostname,
 Type,
 Recipient,
 Args;
}

Declaring multiple variables on the "same line" like in the ChannelMessage class doesn't buy you anything but costs readability.

internal class ChannelMessage
{
 public DateTime Time;
 public string
 Nickname,
 Realname,
 Hostname,
 Type,
 Recipient,
 Args;
}
Source Link
Heslacher
  • 50.9k
  • 5
  • 83
  • 177
Loading
lang-cs

AltStyle によって変換されたページ (->オリジナル) /