Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

Just noticed this

private Section[] GetHoriztonalSections() 

which is IMO correct, but this

private short[] GenerateSection(Section section) 

should be named somehow different, because it isn't generating a Section.


public void SaveImage(string filename, ImageFormat imageFormat)

this should be improved by not using SetPixel() because it is just too slow.

You should create the image as array and then copy the whole array copy the whole array to a bitmap.

Just noticed this

private Section[] GetHoriztonalSections() 

which is IMO correct, but this

private short[] GenerateSection(Section section) 

should be named somehow different, because it isn't generating a Section.


public void SaveImage(string filename, ImageFormat imageFormat)

this should be improved by not using SetPixel() because it is just too slow.

You should create the image as array and then copy the whole array to a bitmap.

Just noticed this

private Section[] GetHoriztonalSections() 

which is IMO correct, but this

private short[] GenerateSection(Section section) 

should be named somehow different, because it isn't generating a Section.


public void SaveImage(string filename, ImageFormat imageFormat)

this should be improved by not using SetPixel() because it is just too slow.

You should create the image as array and then copy the whole array to a bitmap.

Source Link
Heslacher
  • 50.9k
  • 5
  • 83
  • 177

Just noticed this

private Section[] GetHoriztonalSections() 

which is IMO correct, but this

private short[] GenerateSection(Section section) 

should be named somehow different, because it isn't generating a Section.


public void SaveImage(string filename, ImageFormat imageFormat)

this should be improved by not using SetPixel() because it is just too slow.

You should create the image as array and then copy the whole array to a bitmap.

lang-cs

AltStyle によって変換されたページ (->オリジナル) /