Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

I don't see any problems with that. It's similar to this answer on SO this answer on SO.

Just a couple minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

  • Don't forget var in front of the i variable, otherwise it becomes global

I don't see any problems with that. It's similar to this answer on SO.

Just a couple minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

  • Don't forget var in front of the i variable, otherwise it becomes global

I don't see any problems with that. It's similar to this answer on SO.

Just a couple minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

  • Don't forget var in front of the i variable, otherwise it becomes global

added 90 characters in body
Source Link
seand
  • 2.5k
  • 1
  • 20
  • 29

I don't see any problems with that. It's similar to this answer on SO.

Just 2a couple minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

  • Don't forget var in front of the i variable, otherwise it becomes global

I don't see any problems with that. It's similar to this answer on SO.

Just 2 minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

I don't see any problems with that. It's similar to this answer on SO.

Just a couple minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

  • Don't forget var in front of the i variable, otherwise it becomes global

Source Link
seand
  • 2.5k
  • 1
  • 20
  • 29

I don't see any problems with that. It's similar to this answer on SO.

Just 2 minor things:

  • You don't need args in the empty log function

  • You should make the entire function anonymous and execute it immediately (as it's being done in the answer I linked to); I don't think there's any usecase for calling it otherwise

default

AltStyle によって変換されたページ (->オリジナル) /