Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

##Bug!

Bug!

I've just installed ReSharper, and it made an interesting observation:

var currentWeekOfQuarter = 1;

This variable can be converted to a constant - it's never incremented... and that's a bug!

It should be incremented along with currentWeekOfYear:

currentWeekOfYear++;
currentWeekOfQuarter++;

This also means that you are missing at least one unit test, otherwise this would have easily been picked up.

##Bug!

I've just installed ReSharper, and it made an interesting observation:

var currentWeekOfQuarter = 1;

This variable can be converted to a constant - it's never incremented... and that's a bug!

It should be incremented along with currentWeekOfYear:

currentWeekOfYear++;
currentWeekOfQuarter++;

This also means that you are missing at least one unit test, otherwise this would have easily been picked up.

Bug!

I've just installed ReSharper, and it made an interesting observation:

var currentWeekOfQuarter = 1;

This variable can be converted to a constant - it's never incremented... and that's a bug!

It should be incremented along with currentWeekOfYear:

currentWeekOfYear++;
currentWeekOfQuarter++;

This also means that you are missing at least one unit test, otherwise this would have easily been picked up.

Source Link
Mathieu Guindon
  • 75.5k
  • 18
  • 194
  • 467

##Bug!

I've just installed ReSharper, and it made an interesting observation:

var currentWeekOfQuarter = 1;

This variable can be converted to a constant - it's never incremented... and that's a bug!

It should be incremented along with currentWeekOfYear:

currentWeekOfYear++;
currentWeekOfQuarter++;

This also means that you are missing at least one unit test, otherwise this would have easily been picked up.

lang-cs

AltStyle によって変換されたページ (->オリジナル) /