Skip to main content
Code Review

Return to Answer

fixed formatting
Source Link
seand
  • 2.5k
  • 1
  • 20
  • 29

$(function() {

$(function() {
 
 var togglePlusMin = function(clicker, img) {
 $(clicker).toggle(function() {
 $(img).attr("src", "minus.png");
 }, function() {
 $(img).attr("src", "plus.png");
 });
};
// can be used by
togglePlusMin('#togglemass', '#plusmass'); 

// BONUS: this will also work:
var star = $('#togglestar'),
 starIcon = $('img.plusstar');
togglePlusMin(star, starIcon);

})

})

As a comment, its generally a bad idea to use ids without a second context parameter

$(function() {

var togglePlusMin = function(clicker, img) {
 $(clicker).toggle(function() {
 $(img).attr("src", "minus.png");
 }, function() {
 $(img).attr("src", "plus.png");
 });
};
// can be used by
togglePlusMin('#togglemass', '#plusmass'); 
// BONUS: this will also work:
var star = $('#togglestar'),
 starIcon = $('img.plusstar');
togglePlusMin(star, starIcon);

})


As a comment, its generally a bad idea to use ids without a second context parameter

$(function() {
 
 var togglePlusMin = function(clicker, img) {
 $(clicker).toggle(function() {
 $(img).attr("src", "minus.png");
 }, function() {
 $(img).attr("src", "plus.png");
 });
};
// can be used by
togglePlusMin('#togglemass', '#plusmass'); 

// BONUS: this will also work:
var star = $('#togglestar'),
 starIcon = $('img.plusstar');
togglePlusMin(star, starIcon);
})

As a comment, its generally a bad idea to use ids without a second context parameter

Source Link
George Mauer
  • 1.6k
  • 11
  • 13

$(function() {

var togglePlusMin = function(clicker, img) {
 $(clicker).toggle(function() {
 $(img).attr("src", "minus.png");
 }, function() {
 $(img).attr("src", "plus.png");
 });
};
// can be used by
togglePlusMin('#togglemass', '#plusmass'); 
// BONUS: this will also work:
var star = $('#togglestar'),
 starIcon = $('img.plusstar');
togglePlusMin(star, starIcon);

})

As a comment, its generally a bad idea to use ids without a second context parameter

default

AltStyle によって変換されたページ (->オリジナル) /