I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is actually correct and there are likely other things about it that could be reviewed, how should we proceed?
A (now-deleted) example is here here. This asks almost exclusively for correctness (which is easily verified). This is somewhat against the FAQ (as per 5. To the best of my knowledge, does the code work?), although it could be argued that since it is correct, it's valid by this criterion.
What should be done with questions like this? Leave it be and give an actual "code review" even if isn't what was asked for, or close the question as off topic?
I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is actually correct and there are likely other things about it that could be reviewed, how should we proceed?
A (now-deleted) example is here. This asks almost exclusively for correctness (which is easily verified). This is somewhat against the FAQ (as per 5. To the best of my knowledge, does the code work?), although it could be argued that since it is correct, it's valid by this criterion.
What should be done with questions like this? Leave it be and give an actual "code review" even if isn't what was asked for, or close the question as off topic?
I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is actually correct and there are likely other things about it that could be reviewed, how should we proceed?
A (now-deleted) example is here. This asks almost exclusively for correctness (which is easily verified). This is somewhat against the FAQ (as per 5. To the best of my knowledge, does the code work?), although it could be argued that since it is correct, it's valid by this criterion.
What should be done with questions like this? Leave it be and give an actual "code review" even if isn't what was asked for, or close the question as off topic?
- 35.2k
- 2
- 54
- 106
How toshould one deal with code asking "Is this correct"correct?" when it is in fact correct?
I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what CodereviewCode Review is about. However, when the code is actually correct and there are likely other things about it that could be reviewed, how should we proceed?
AnA (now-deleted) example is here. This asks almost exclusively for correctness (which is easily verified). This is somewhat against the FAQ (as per 5. To the best of my knowledge, does the code work?), although it could be argued that since it is correct, it's valid by this criterion.
What should be done with questions like this? Leave it be and give an actual "code review" even if isn't what was asked for, or close the question as Offoff topic?
How to deal with code asking "Is this correct" when it is in fact correct
I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Codereview is about. However, when the code is actually correct and there are likely other things about it that could be reviewed, how should we proceed?
An example is here. This asks almost exclusively for correctness (which is easily verified). This is somewhat against the FAQ (as per 5. To the best of my knowledge, does the code work?), although it could be argued that since it is correct, it's valid by this criterion.
What should be done with questions like this? Leave it be and give an actual "code review" even if isn't what was asked for, or close the question as Off topic?
How should one deal with code asking "Is this correct?" when it is in fact correct?
I'm wondering what a good guideline is when dealing with questions asking (primarily or completely) about correctness. Generally this is not what Code Review is about. However, when the code is actually correct and there are likely other things about it that could be reviewed, how should we proceed?
A (now-deleted) example is here. This asks almost exclusively for correctness (which is easily verified). This is somewhat against the FAQ (as per 5. To the best of my knowledge, does the code work?), although it could be argued that since it is correct, it's valid by this criterion.
What should be done with questions like this? Leave it be and give an actual "code review" even if isn't what was asked for, or close the question as off topic?