Issue 98510043: Move osenv.(Set)Home functions to utils.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(1167)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 98510043: Move osenv.(Set)Home functions to utils.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by frankban

Modified:
11 years, 7 months ago

Reviewers:
mp+220811, fwereade, rog

Visibility:
Public.

Move osenv.(Set)Home functions to utils. This is an incremental step towards the goal to remove the osenv dependency from utils. https://code.launchpad.net/~frankban/juju-core/osenv-home/+merge/220811 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move osenv.(Set)Home functions to utils. #

Patch Set 3 : Move osenv.(Set)Home functions to utils. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -64 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/filevar_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/deploy_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/config/authkeys.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	environs/config/authkeys_test.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/filestorage/filestorage_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	juju/osenv/home.go	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	juju/osenv/package_test.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	juju/testing/conn.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	provider/ec2/config_test.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	provider/local/config_test.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	testing/base.go	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	testing/base_test.go	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	testing/environ_test.go	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	utils/file.go	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	utils/file_test.go	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	utils/fslock/package_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/home_unix.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	utils/home_unix_test.go	View	1 chunk	+11 lines, -4 lines	0 comments	Download
M	utils/home_windows.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/home_windows_test.go	View	1 chunk	+13 lines, -7 lines	0 comments	Download
A	utils/package_test.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Total messages: 5

frankban

Please take a look.

11 years, 7 months ago (2014年05月23日 14:23:22 UTC) #1

Please take a look.

rog

LGTM modulo the below. https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go File juju/osenv/package_test.go (right): https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#newcode25 juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) { ...

11 years, 7 months ago (2014年05月23日 16:49:06 UTC) #2

LGTM modulo the below.
https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go
File juju/osenv/package_test.go (right):
https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#new...
juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) {
I think this test should be moved to utils instead of skipped.

fwereade

https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go File juju/osenv/package_test.go (right): https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#newcode25 juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) { On 2014年05月23日 16:49:06, rog ...

11 years, 7 months ago (2014年05月26日 07:35:38 UTC) #3

https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go
File juju/osenv/package_test.go (right):
https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#new...
juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) {
On 2014年05月23日 16:49:06, rog wrote:
> I think this test should be moved to utils instead of skipped.
+1

frankban

Please take a look. https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go File juju/osenv/package_test.go (right): https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#newcode25 juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) { ...

11 years, 7 months ago (2014年05月26日 08:51:55 UTC) #4

Please take a look.
https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go
File juju/osenv/package_test.go (right):
https://codereview.appspot.com/98510043/diff/1/juju/osenv/package_test.go#new...
juju/osenv/package_test.go:25: func (*importSuite) TestDependencies(c *gc.C) {
On 2014年05月23日 16:49:06, rog wrote:
> I think this test should be moved to utils instead of skipped.
Done.

frankban

Please take a look.

11 years, 7 months ago (2014年05月26日 08:56:15 UTC) #5

Please take a look.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b