Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(309)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 97570046: code review 97570046: encoding/xml: Trim XML tags correctly before printing chardata.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by hajimehoshi
Modified:
11 years ago
Reviewers:
CC:
golang-codereviews, bradfitz, rsc
Visibility:
Public.
encoding/xml: Trim XML tags correctly before printing chardata. This fixes issue 5072. This doesn't consider about fixed-size arrays. (AFAIK, (a part of) an xml can't be unmarshaled to fixed-size arrays.)

Patch Set 1 #

Patch Set 2 : diff -r 962157789bb0 https://code.google.com/p/go #

Patch Set 3 : diff -r 962157789bb0 https://code.google.com/p/go #

Created: 11 years, 7 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/pkg/encoding/xml/marshal.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 1 2 chunks +9 lines, -0 lines 0 comments Download
Total messages: 6
|
hajimehoshi
Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2014年05月21日 10:04:36 UTC) #1
Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go 
Sign in to reply to this message.
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
11 years, 7 months ago (2014年05月21日 10:08:23 UTC) #2
Replacing golang-dev with golang-codereviews.
To the author of this CL: 
If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.
If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.
Thanks very much.
Sign in to reply to this message.
hajimehoshi
ping
11 years, 6 months ago (2014年06月23日 08:33:50 UTC) #3
ping
Sign in to reply to this message.
bradfitz
R=rsc
11 years, 6 months ago (2014年06月23日 17:36:09 UTC) #4
R=rsc
Sign in to reply to this message.
hajimehoshi
I was wondering someone would review this.
11 years, 5 months ago (2014年07月30日 06:21:23 UTC) #5
I was wondering someone would review this.
Sign in to reply to this message.
gobot
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
11 years ago (2014年12月19日 05:19:30 UTC) #6
R=close
To the author of this CL:
The Go project has moved to Gerrit Code Review.
If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.
If there has been discussion on this CL, please give a link to it
(golang.org/cl/97570046 is best) in the description in your
new CL.
Thanks very much.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /