Issue 95150043: environs/manual: use old AddMAchines API

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(235)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 95150043: environs/manual: use old AddMAchines API

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by axw

Modified:
11 years, 8 months ago

Reviewers:
gz , mp+218746

Visibility:
Public.

environs/manual: use old AddMAchines API Manual provisioning was implicitly changed to use the new AddMachinesV2 client API, with no backwards compatibility failover. I've changed it to explicitly use the old API, since we do not require anything of the new one. Fixes lp:1317267 https://code.launchpad.net/~axwalk/juju-core/lp1317267-manual-addmachine1dot18/+merge/218746 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/manual: use old AddMAchines API #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/manual/provisioner.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4

axw

Please take a look.

11 years, 8 months ago (2014年05月08日 07:02:05 UTC) #1

Please take a look.

LGTM. A comment here saying only the 1.18 api is needed wouldn't hurt.

11 years, 8 months ago (2014年05月08日 07:55:11 UTC) #2

LGTM. A comment here saying only the 1.18 api is needed wouldn't hurt.

LGTM. A comment here saying only the 1.18 api is needed wouldn't hurt.

11 years, 8 months ago (2014年05月08日 07:55:13 UTC) #3

LGTM. A comment here saying only the 1.18 api is needed wouldn't hurt.

axw

Please take a look.

11 years, 8 months ago (2014年05月08日 10:10:35 UTC) #4

Please take a look.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b