Issue 92520043: juju/cmd: introduced "user" command

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(164)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 92520043: juju/cmd: introduced "user" command

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by menn0

Modified:
11 years, 7 months ago

Reviewers:
waigani , dave, mp+220148

Visibility:
Public.

juju/cmd: introduced "user" command "juju user" now exists. It is a SuperCommand and the existing "add-user" command is now wired up as "juju user add" instead. https://code.launchpad.net/~menno.smits/juju-core/user-supercommand/+merge/220148 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -34 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/main.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cmd/juju/main_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	cmd/juju/removeuser_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
A	cmd/juju/user.go	View	1 chunk	+35 lines, -0 lines	1 comment	Download
M	cmd/juju/user_add.go	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	cmd/juju/user_add_test.go	View	4 chunks	+22 lines, -22 lines	0 comments	Download
A	cmd/juju/user_test.go	View	1 chunk	+42 lines, -0 lines	0 comments	Download

Total messages: 5

menn0

Please take a look.

11 years, 7 months ago (2014年05月20日 02:53:52 UTC) #1

Please take a look.

waigani

On 2014年05月20日 02:53:52, menn0 wrote: > Please take a look. LGTM, with minor comment about ...

11 years, 7 months ago (2014年05月20日 03:45:22 UTC) #2

On 2014年05月20日 02:53:52, menn0 wrote:
> Please take a look.
LGTM, with minor comment about whitespace. Though you may want a second opinion
as I'm a newbie.

waigani

https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go File cmd/juju/user.go (right): https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go#newcode18 cmd/juju/user.go:18: It seems most of the docs don't have whitespace.

11 years, 7 months ago (2014年05月20日 03:56:20 UTC) #3

https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go
File cmd/juju/user.go (right):
https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go#newcode18
cmd/juju/user.go:18: 
It seems most of the docs don't have whitespace.

dave_cheney.net

LGTM. Glad it turned out to be simple.

11 years, 7 months ago (2014年05月20日 04:17:11 UTC) #4

LGTM. Glad it turned out to be simple.

menn0

On 2014年05月20日 03:56:20, waigani wrote: > https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go > File cmd/juju/user.go (right): > > https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go#newcode18 > ...

11 years, 7 months ago (2014年05月20日 04:25:13 UTC) #5

On 2014年05月20日 03:56:20, waigani wrote:
> https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go
> File cmd/juju/user.go (right):
> 
> https://codereview.appspot.com/92520043/diff/1/cmd/juju/user.go#newcode18
> cmd/juju/user.go:18: 
> It seems most of the docs don't have whitespace.
Good spot. Fixed.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b