Issue 92190043: oauth2: fixing abstractions to provide external token fetcher

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(174)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 92190043: oauth2: fixing abstractions to provide external token fetcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by jbd

Modified:
11 years, 8 months ago

Reviewers:
adg

Visibility:
Public.

More Reviews

oauth2: fixing abstractions to provide external token fetcher I think I can remove Config and JWTConfig interfaces and make the implementations public.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Adding GCE token fetcher #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -90 lines)			Patch
M	google/google.go	View	1 2	3 chunks	+65 lines, -16 lines	0 comments	Download
M	jwt.go	View	1	1 chunk	+16 lines, -10 lines	0 comments	Download
M	oauth2.go	View	1	10 chunks	+25 lines, -59 lines	0 comments	Download
M	oauth2_test.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	transport.go	View	2 chunks	+9 lines, -2 lines	0 comments	Download

Total messages: 2

jbd

PTAL

11 years, 8 months ago (2014年05月13日 09:46:54 UTC) #1

PTAL