Issue 8881: GTest build broken on z/OS

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(59)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 8881: GTest build broken on z/OS

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 1 month ago by Hobbes

Modified:
16 years, 5 months ago

Reviewers:
chandlerc, Zhanyong, googletestframework

Base URL:
http://googletest.googlecode.com/svn/trunk/

Visibility:
Public.

Obviously I missed something that should have been covered by the patch in http://codereview.appspot.com/7855/show. Unfortunately it wasn't until today that I had the chance to build on z/OS again.

Patch Set 1 #

Patch Set 2 : also remove comments about 'no autoconf' #

Created: 17 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
src/gtest.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5

Hobbes

17 years, 1 month ago (2008年12月02日 18:20:15 UTC) #1

chandlerc

http://codereview.appspot.com/8881/diff/1/2 File src/gtest.cc (right): http://codereview.appspot.com/8881/diff/1/2#newcode69 Line 69: // No autoconf on z/OS While this line ...

17 years, 1 month ago (2008年12月02日 18:26:36 UTC) #2

http://codereview.appspot.com/8881/diff/1/2
File src/gtest.cc (right):
http://codereview.appspot.com/8881/diff/1/2#newcode69
Line 69: // No autoconf on z/OS
While this line is present in the SYMBIAN section above, I don't think we use
autoconf to detect anything currently, so I might remove both comments. What do
others think?

Zhanyong

http://codereview.appspot.com/8881/diff/1/2 File src/gtest.cc (right): http://codereview.appspot.com/8881/diff/1/2#newcode69 Line 69: // No autoconf on z/OS On 2008年12月02日 18:26:37, ...

17 years, 1 month ago (2008年12月02日 18:32:11 UTC) #3

http://codereview.appspot.com/8881/diff/1/2
File src/gtest.cc (right):
http://codereview.appspot.com/8881/diff/1/2#newcode69
Line 69: // No autoconf on z/OS
On 2008年12月02日 18:26:37, chandlerc wrote:
> While this line is present in the SYMBIAN section above, I don't think we use
> autoconf to detect anything currently, so I might remove both comments. What
do
> others think?
Sounds good.

Hobbes

also remove comments about 'no autoconf'

17 years, 1 month ago (2008年12月02日 19:20:07 UTC) #4

also remove comments about 'no autoconf'

chandlerc

LGTM

17 years, 1 month ago (2008年12月02日 19:52:15 UTC) #5

LGTM

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b