Issue 83090044: state/api: listen on localhost explicitly

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(21)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 83090044: state/api: listen on localhost explicitly

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rog

Modified:
11 years, 9 months ago

Reviewers:
wwitzel3 , mp+213675, mfoord

Visibility:
Public.

state/api: listen on localhost explicitly If we listen on ":0", the address returned from Addr is all-zeros, which is not always valid for dialling localhost. (I'm not sure why it ever is, actually) So we listen on 127.0.0.1 explicitly. https://code.launchpad.net/~rogpeppe/juju-core/537-listen-localhost/+merge/213675 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/local/local_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/apiclient_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/api/client_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

rog

Please take a look.

11 years, 9 months ago (2014年04月01日 15:32:26 UTC) #1

Please take a look.

mfoord

On 2014年04月01日 15:32:26, rog wrote: > Please take a look. LGTM

11 years, 9 months ago (2014年04月01日 15:34:34 UTC) #2

On 2014年04月01日 15:32:26, rog wrote:
> Please take a look.
LGTM

wwitzel3

LGTM

11 years, 9 months ago (2014年04月01日 15:34:56 UTC) #3

LGTM