---

File u : up to issue m : publish + mail comments M : edit review message j / k : jump to file after / before current file J / K : jump to next file with a comment after / before current file Side-by-side diff i : toggle intra-line diffs e : expand all comments c : collapse all comments s : toggle showing all comments n / p : next / previous diff chunk or comment N / P : next / previous comment <Up> / <Down> : next / previous line <Enter> : respond to / edit current comment d : mark current comment as done

Issue u : up to list of issues m : publish + mail comments j / k : jump to patch after / before current patch o / <Enter> : open current patch in side-by-side view i : open current patch in unified diff view Issue List j / k : jump to issue after / before current issue o / <Enter> : open current issue # : close issue Comment/message editing <Ctrl> + s or <Ctrl> + Enter : save comment <Esc> : cancel edit

Help | Bug tracker | Discussion group | Source code | Sign in

(295)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 818047: Code review for https://bugs.webkit.org/show_bug.cgi?id=37418

Can't Edit Can't Publish+Mail Start Review Created: 15 years, 9 months ago by Adam Barth Modified: 15 years, 9 months ago Reviewers: CC: eric_webkit.org, cjerdonek_webkit.org Visibility: Public.

Patch Set 1 # Created: 15 years, 9 months ago Download [raw] [tar.bz2] Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -13 lines) Patch M WebKitTools/ChangeLog View 1 chunk +28 lines, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/common/config/__init__.py View 1 chunk +6 lines, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/common/net/rietveld.py View 3 chunks +4 lines, -4 lines 0 comments Download M WebKitTools/Scripts/webkitpy/common/net/rietveld_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/commands/queues_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/commands/upload.py View 2 chunks +2 lines, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/commands/upload_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/main.py View 3 chunks +3 lines, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/mocktool.py View 4 chunks +9 lines, -1 line 0 comments Download M WebKitTools/Scripts/webkitpy/tool/steps/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/steps/options.py View 1 chunk +1 line, -0 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/steps/postcodereview.py View 3 chunks +21 lines, -5 lines 0 comments Download M WebKitTools/Scripts/webkitpy/tool/steps/postdiff.py View 1 chunk +5 lines, -1 line 0 comments Download

Issue 818047: Code review for https://bugs.webkit.org/show_bug.cgi?id=37418
Created 15 years, 9 months ago by Adam Barth
Modified 15 years, 9 months ago
Reviewers:
Base URL:
Comments: 0

Powered by Google App Engine