|
|
|
doc/go1.1.html: add info about remaining net changes
Patch Set 1 #Patch Set 2 : diff -r 2bc153c7d415 https://code.google.com/p/go/ #Patch Set 3 : diff -r 2bc153c7d415 https://code.google.com/p/go/ #
Total comments: 4
Total messages: 6
|
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
|
12 years, 9 months ago (2013年03月25日 22:40:18 UTC) #1 |
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
LGTM https://codereview.appspot.com/8021043/diff/3002/doc/go1.1.html File doc/go1.1.html (right): https://codereview.appspot.com/8021043/diff/3002/doc/go1.1.html#newcode428 doc/go1.1.html:428: add a new field <code>Zone string</code>. maybe add a new string field called Zone. https://codereview.appspot.com/8021043/diff/3002/doc/go1.1.html#newcode430 doc/go1.1.html:430: <code>net.TCPAddr{IP: ip, Port: port}</code> will break due to the new field. Code using untagged literals (example1) instead of tagged literals (example2) will break due to the new field. https://codereview.appspot.com/8021043/diff/3002/doc/go1.1.html#newcode437 doc/go1.1.html:437: <code>go fix</code> will rewrite code like <code>net.TCPAddr{ip, port}</code> to <code>net.TCPAddr{IP: ip, Port: port}</code>. maybe just go fix will rewrite code to add tags to these types? https://codereview.appspot.com/8021043/diff/3002/doc/go1.1.html#newcode743 doc/go1.1.html:743: The <a href="/pkg/net/"><code>net</code></a> package adds support for link-local IPv6 addresses with zone qualifiers, such as “<code>fe80::1%lo0</code>.” The address structures first use of “ why not the ASCII ""?
ping, did this ever get merged ?
On Wed, Apr 10, 2013 at 10:47 AM, <dave@cheney.net> wrote: > ping, did this ever get merged ? > > https://codereview.appspot.com/8021043/ This CL is superseded by https://codereview.appspot.com/7741049