Issue 79100043: devdraw cocoa: apply scaling when checking cursor bounds - Code Review

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(443)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 79100043: devdraw cocoa: apply scaling when checking cursor bounds

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by marius.eriksen

Modified:
11 years, 9 months ago

Reviewers:
rsc

CC:
codebot

Visibility:
Public.

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
M	src/cmd/devdraw/cocoa-screen.m	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 2

|

marius.eriksen

11 years, 9 months ago (2014年03月22日 16:39:19 UTC) #1

Sign in to reply to this message.

rsc

what does this fix? i'm sure it's fine, i am just curious if i've seen ...

11 years, 9 months ago (2014年03月24日 22:53:47 UTC) #2

what does this fix? i'm sure it's fine, i am just curious if i've seen the
bad behavior.

Sign in to reply to this message.

|

Powered by Google App Engine

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b