Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(390)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7853: Review queue overview page. Quick hack just to reduce our workload.

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 2 months ago by Evan Martin
Modified:
16 years, 5 months ago
Reviewers:
JohnA
Visibility:
Public.
Review queue overview page. Quick hack just to reduce our workload.

Patch Set 1 #

Patch Set 2 : update #

Created: 17 years, 2 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M codereview/urls.py View 1 chunk +1 line, -0 lines 0 comments Download
M codereview/views.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
A templates/overview.html View 1 chunk +31 lines, -0 lines 0 comments Download
Total messages: 4
|
Evan Martin
17 years, 2 months ago (2008年10月22日 20:15:10 UTC) #1
Sign in to reply to this message.
JohnA
http://codereview.appspot.com/7853/diff/1/3 File codereview/views.py (right): http://codereview.appspot.com/7853/diff/1/3#newcode604 Line 604: emails = emails[:5] # Arbitrary limit just to ...
17 years, 2 months ago (2008年10月22日 20:42:50 UTC) #2
http://codereview.appspot.com/7853/diff/1/3
File codereview/views.py (right):
http://codereview.appspot.com/7853/diff/1/3#newcode604
Line 604: emails = emails[:5] # Arbitrary limit just to avoid excessive
hammering.
hmm this is the sort of thing that will be easy to forget about in the future
and we'll be stuck trying to figure out why this isn't working... why don't you
pick something bigger like 20 for now, and maybe if they give more than 20,
return a 404 or a page with an error?
Sign in to reply to this message.
Evan Martin
OK, updated
17 years, 2 months ago (2008年10月22日 22:14:00 UTC) #3
OK, updated
Sign in to reply to this message.
JohnA
lgtm
17 years, 2 months ago (2008年10月23日 21:17:18 UTC) #4
lgtm
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /