|
|
|
state: modify SetAPIAddresses to SetAPIHostPorts
We want to keep all the available metadata in the
state, so that clients can be more intelligent about
connecting.
We can keep the existing APIAddresses API call,
but augment it with another call that returns
all the metadata too.
https://code.launchpad.net/~rogpeppe/juju-core/524-state-api-hostports/+merge/211736
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : state: modify SetAPIAddresses to SetAPIHostPorts #Patch Set 3 : state: modify SetAPIAddresses to SetAPIHostPorts #
Total comments: 2
Total messages: 4
|
rog
Please take a look.
|
11 years, 9 months ago (2014年03月19日 14:20:47 UTC) #1 | ||||||||||||||||||||||||||||||||||||||||||||||||||
Please take a look.
Please take a look.
LGTM. I'm not completely clear on the migration implications, I guess we just get the new document populated and if we leave the old one around it doesn't matter much? https://codereview.appspot.com/77820043/diff/40001/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/77820043/diff/40001/state/state_test.go#newcod... state/state_test.go:2898: }, Port defaults to 0 here? What does that mean?
I don't think there are any migration implications. The document isn't used by anything yet. https://codereview.appspot.com/77820043/diff/40001/state/state_test.go File state/state_test.go (right): https://codereview.appspot.com/77820043/diff/40001/state/state_test.go#newcod... state/state_test.go:2898: }, On 2014年03月19日 16:34:33, gz wrote: > Port defaults to 0 here? What does that mean? it means i should set it to something :-)