Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(138)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 73070043: code review 73070043: mime: update hardcoded mimetype for ".js"

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by minux1
Modified:
11 years, 5 months ago
Visibility:
Public.
mime: update hardcoded mimetype for ".js" According to RFC 4329, it should be "application/javascript", not "application/x-javascript".

Patch Set 1 #

Patch Set 2 : diff -r f7021118727a https://code.google.com/p/go #

Patch Set 3 : diff -r f7021118727a https://code.google.com/p/go #

Created: 11 years, 10 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/mime/type.go View 1 1 chunk +1 line, -1 line 0 comments Download
Total messages: 3
|
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 10 months ago (2014年03月08日 21:47:15 UTC) #1
Hello golang-codereviews@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go 
Sign in to reply to this message.
bradfitz
I think we need more justification showing research that this is safe and okay. A ...
11 years, 10 months ago (2014年03月08日 22:35:39 UTC) #2
I think we need more justification showing research that this is safe and
okay.
A document saying that it's correct is often not enough on the web.
Why do the libraries served from
https://developers.google.com/speed/libraries/devguide have text/javascript?
$ curl -A "Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/32.0.1667.0 Safari/537.36" -v
http://ajax.googleapis.com/ajax/libs/angularjs/1.2.12/angular.min.js 2>&1 |
grep Content-Type | head -1
< Content-Type: text/javascript; charset=UTF-8
On Sat, Mar 8, 2014 at 1:47 PM, <minux.ma@gmail.com> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> mime: update hardcoded mimetype for ".js"
> According to RFC 4329, it should be "application/javascript",
> not "application/x-javascript".
>
> Please review this at https://codereview.appspot.com/73070043/
>
> Affected files (+1, -1 lines):
> M src/pkg/mime/type.go
>
>
> Index: src/pkg/mime/type.go
> ===================================================================
> --- a/src/pkg/mime/type.go
> +++ b/src/pkg/mime/type.go
> @@ -17,7 +17,7 @@
> ".htm": "text/html; charset=utf-8",
> ".html": "text/html; charset=utf-8",
> ".jpg": "image/jpeg",
> - ".js": "application/x-javascript",
> + ".js": "application/javascript",
> ".pdf": "application/pdf",
> ".png": "image/png",
> ".xml": "text/xml; charset=utf-8",
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.
gobot
R=close (assigned by dave@cheney.net)
11 years, 5 months ago (2014年07月16日 11:03:05 UTC) #3
R=close (assigned by dave@cheney.net)
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /