|
|
|
Updating GCE PHP Getting Started sample to v1beta14
Patch Set 1 #
Total comments: 1
Patch Set 2 : Removal of Developer Key setting and updates to README instructions #Total messages: 5
|
jbsimon
|
12 years, 11 months ago (2013年02月13日 22:53:55 UTC) #1 |
The app.php file looks good, aside from the one comment. I have some suggestions for the README file: - Add a link to the php client library at this line "The google-api-php-client library checked out locally" - In this sentence: "Under the redirect URI, enter the location of your JavaScript application" - was this copied from the JavaScript demo? You might want to remove the word JavaScript to avoid confusion. - Under the setup section, step 2, add a bullet for the $project variable. https://codereview.appspot.com/7301093/diff/1/app.php File app.php (right): https://codereview.appspot.com/7301093/diff/1/app.php#newcode38 app.php:38: $client->setDeveloperKey('YOUR_DEVELOPER_KEY'); Is the developer key really necessary? It's not mentioned in the README, and I don't think it's necessary to use the API. I recommend removing this line.
On 2013年02月16日 00:47:43, jbsimon wrote: - Removed the code to set Developer Key in app.php - Updated the README.md file to remove and add instructions
LGTM! I totally missed the project key in the README, but in any case, I think it's good to remove it since it's not necessary. Thanks!