Issue 7268: "final" attribute for gcc

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(297)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7268: "final" attribute for gcc

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 3 months ago by Jeffrey Yasskin

Modified:
16 years, 5 months ago

Reviewers:

Base URL:
svn://gcc.gnu.org/svn/gcc/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Post-Ian's Review #

Created: 17 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -1 line)			Patch
M	gcc/cp/class.c	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
M	gcc/cp/decl.c	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	gcc/cp/search.c	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	gcc/cp/tree.c	View	1	3 chunks	+27 lines, -0 lines	1 comment	Download
M	gcc/doc/extend.texi	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	gcc/testsuite/g++.dg/inherit/final1.C	View	1	1 chunk	+76 lines, -0 lines	0 comments	Download
A	gcc/testsuite/g++.dg/inherit/final2.C	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Total messages: 2

Jeffrey Yasskin

17 years, 3 months ago (2008年10月08日 17:21:27 UTC) #1

Jeffrey Yasskin

http://codereview.appspot.com/7268/diff/210/17 File gcc/cp/tree.c (right): http://codereview.appspot.com/7268/diff/210/17#newcode2326 Line 2326: /* Return a new PTRMEM_CST of the indicated ...

17 years, 3 months ago (2008年10月09日 04:51:48 UTC) #2

http://codereview.appspot.com/7268/diff/210/17
File gcc/cp/tree.c (right):
http://codereview.appspot.com/7268/diff/210/17#newcode2326
Line 2326: /* Return a new PTRMEM_CST of the indicated TYPE. The MEMBER is the
Added the missing blank line here in my copy.