Issue 72310044: agent/mongo: Revert attempted use of juju-mongodb

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(119)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 72310044: agent/mongo: Revert attempted use of juju-mongodb

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by gz

Modified:
11 years, 10 months ago

Reviewers:
mp+209959, jameinel , natefinch

Visibility:
Public.

agent/mongo: Revert attempted use of juju-mongodb Currently upstart scripts are generated on the client and included in the cloud-init data. The change to check for the existence of the new juju-mongodb package breaks remote bootstrap, as it will see the alternative location locally with a stat, then generate an upstart file that the spawned machine cannot use. This branch reverts to using a hard coded path where mongod can be found. Future work will cover moving the upstart script generatation off the the client and onto the server so it can actually do the right thing. https://code.launchpad.net/~gz/juju-core/revert_upstart_mongodb_1286279/+merge/209959 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	agent/mongo/mongo.go	View	2 chunks	+1 line, -6 lines	0 comments	Download

Total messages: 3

Please take a look.

11 years, 10 months ago (2014年03月07日 16:18:53 UTC) #1

Please take a look.

jameinel

LGTM, but I don't mind having someone else give it a look.

11 years, 10 months ago (2014年03月07日 16:20:42 UTC) #2

LGTM, but I don't mind having someone else give it a look.

natefinch

On 2014年03月07日 16:20:42, jameinel wrote: > LGTM, but I don't mind having someone else give ...

11 years, 10 months ago (2014年03月07日 16:22:54 UTC) #3

On 2014年03月07日 16:20:42, jameinel wrote:
> LGTM, but I don't mind having someone else give it a look.
LGTM. Thanks.