Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7205056: net/url: allow resolution of "" and "#fragment"

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by rodrigo.moraes
Modified:
12 years, 11 months ago
Reviewers:
adg, bradfitz
Visibility:
Public.
net/url: allow resolution of "" and "#fragment" Currently URL.Parse("") or URL.Parse("#fragment") result in an error, but they should be correctly resolved as same-document references. This patch fixes this, allowing URL.Parse() to receive "" or "#fragment". I'm being conservative not implementing in Parse() because this could be considered an API break, since empty strings resulted in error before. However it sounds like a bug to me and an ideal solution would be that Parse() could receive such arguments as well, so that URL.ResolveReference() could also resolve same-document references. Let me know if this sounds reasonable and I'll send a new patch.

Patch Set 1 #

Patch Set 2 : net/url: allow resolution of "" and "#fragment" #

Created: 12 years, 11 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M src/pkg/net/url/url.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/net/url/url_test.go View 1 2 chunks +22 lines, -7 lines 0 comments Download
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /