Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7142053: [Google 4.7] Fix for Google Ref: b/8028506

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by saugustine
Modified:
12 years, 12 months ago
Reviewers:
Cary
CC:
gcc-patches_gcc.gnu.org
Visibility:
Public.
commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c Author: Sterling Augustine <saugustine@google.com> Date: Fri Jan 18 10:38:30 2013 -0800 Fix for Google Ref: b/8028506 Calling find_AT_string can resize the debug_str hash table, even if the string is already present in the hash table--go figure. So after indices have been assigned, and the hash table is exactly three-quarters full, calling find_AT_string is verboten. This change moves some calls around such that the above scenario never happens, all strings will be found and assigned prior to indices being assigned. M gcc/dwarf2out.c Tested: With full bootstrap and fission testing.

Patch Set 1 #

Created: 12 years, 12 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M gcc/dwarf2out.c View 2 chunks +4 lines, -3 lines 0 comments Download
Total messages: 3
|
saugustine
commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c Author: Sterling Augustine <saugustine@google.com> Date: Fri Jan 18 10:38:30 2013 -0800 Fix for ...
12 years, 12 months ago (2013年01月18日 18:45:30 UTC) #1
commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c
Author: Sterling Augustine <saugustine@google.com>
Date: Fri Jan 18 10:38:30 2013 -0800
 Fix for Google Ref: b/8028506
 
 Calling find_AT_string can resize the debug_str hash table, even if the
 string is already present in the hash table--go figure. So after indices
 have been assigned, and the hash table is exactly three-quarters full,
 calling find_AT_string is verboten.
 
 This change moves some calls around such that the above scenario never
 happens, all strings will be found and assigned prior to indices being
 assigned.
M	gcc/dwarf2out.c
Tested:
 With full bootstrap and fission testing.
diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 5ca22b2..5099c39 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -9407,9 +9407,6 @@ output_skeleton_debug_sections (dw_die_ref comp_unit)
 remove_AT (comp_unit, DW_AT_producer);
 remove_AT (comp_unit, DW_AT_language);
 
- /* Add attributes common to skeleton compile_units and type_units. */
- add_top_level_skeleton_die_attrs (comp_unit);
-
 switch_to_section (debug_skeleton_info_section);
 ASM_OUTPUT_LABEL (asm_out_file, debug_skeleton_info_section_label);
 
@@ -24087,6 +24084,10 @@ dwarf2out_finish (const char *filename)
 if (dwarf_split_debug_info)
 {
 unsigned int index = 0;
+ /* Before we assign string indexes, we need to add the string
+	 attributes to the skeleton compile unit and type units. */
+ add_top_level_skeleton_die_attrs (main_comp_unit_die);
+ (void) get_skeleton_type_unit ();
 htab_traverse_noresize (debug_str_hash, index_string, &index);
 }
 
--
This patch is available for review at http://codereview.appspot.com/7142053
Sign in to reply to this message.
Cary
> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c > Author: Sterling Augustine <saugustine@google.com> > Date: Fri Jan 18 10:38:30 2013 ...
12 years, 12 months ago (2013年01月18日 19:04:29 UTC) #2
> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c
> Author: Sterling Augustine <saugustine@google.com>
> Date: Fri Jan 18 10:38:30 2013 -0800
>
> Fix for Google Ref: b/8028506
>
> Calling find_AT_string can resize the debug_str hash table, even if the
> string is already present in the hash table--go figure. So after indices
> have been assigned, and the hash table is exactly three-quarters full,
> calling find_AT_string is verboten.
>
> This change moves some calls around such that the above scenario never
> happens, all strings will be found and assigned prior to indices being
> assigned.
>
> M gcc/dwarf2out.c
OK for google/gcc-4_7.
I'll be filing an upstream bug for this problem, and I'd like to get
this fix into 4.8 as well.
-cary
Sign in to reply to this message.
saugustine
On Fri, Jan 18, 2013 at 11:04 AM, Cary Coutant <ccoutant@google.com> wrote: >> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c ...
12 years, 12 months ago (2013年01月18日 21:50:51 UTC) #3
On Fri, Jan 18, 2013 at 11:04 AM, Cary Coutant <ccoutant@google.com> wrote:
>> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c
>> Author: Sterling Augustine <saugustine@google.com>
>> Date: Fri Jan 18 10:38:30 2013 -0800
>>
>> Fix for Google Ref: b/8028506
>>
>> Calling find_AT_string can resize the debug_str hash table, even if the
>> string is already present in the hash table--go figure. So after
indices
>> have been assigned, and the hash table is exactly three-quarters full,
>> calling find_AT_string is verboten.
>>
>> This change moves some calls around such that the above scenario never
>> happens, all strings will be found and assigned prior to indices being
>> assigned.
>>
>> M gcc/dwarf2out.c
>
> OK for google/gcc-4_7.
>
> I'll be filing an upstream bug for this problem, and I'd like to get
> this fix into 4.8 as well.
>
> -cary
Committed as posted. Thanks. These do need to go into trunk, as they
complicate using fission.
Sterling
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /