|
|
|
Created:
12 years, 12 months ago by abentley-home Modified:
12 years, 12 months ago Reviewers:
hazmat, mp+143175, aaron Visibility:
Public. |
Revno can be configured
With this change, revno is a configurable value. If a non-negative value is
specified, the source is updated to that value. -1 is treated as branch tip,
and does not trigger updates. It is the default. Other negative values are
forbidden.
https://code.launchpad.net/~abentley/charms/precise/charmworld/revno-config/+merge/143175
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 1
Total messages: 3
|
abentley-home
Please take a look.
|
12 years, 12 months ago (2013年01月14日 19:47:28 UTC) #1 | |||||||||||||||||||||||||||||||||||
Please take a look.
looks good, go ahead and merge. https://codereview.appspot.com/7093060/diff/1/hooks/config-changed File hooks/config-changed (right): https://codereview.appspot.com/7093060/diff/1/hooks/config-changed#newcode41 hooks/config-changed:41: update_source its debatable if it should, but should revno -1 opportunistically update?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 13-01-14 02:56 PM, kapilt@gmail.com wrote: > https://codereview.appspot.com/7093060/diff/1/hooks/config-changed#newcode41 > > hooks/config-changed:41: update_source its debatable if it should, > but should revno -1 opportunistically update? If it did, -1 would mean we'd update the source code whenever configuration changed, and I think that would be unexpected. Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlD0ZDMACgkQ0F+nu1YWqI37zQCfZyBx9TzDHQ5bhEQGbcFK8IU1 FGUAnA+ln4RhcGyjBW9bmnVDuAk/6ysu =fjk0 -----END PGP SIGNATURE-----