|
|
|
Environments have uuids (regression fix for subs)
Previous environment uuid work caused issues with subordinates, added
an additional test and one line fix for. Fixes bugs
https://bugs.launchpad.net/juju/+bug/1100245
https://bugs.launchpad.net/juju/+bug/1100348
https://code.launchpad.net/~hazmat/juju/env-id/+merge/143188
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : Environments have uuids. #Patch Set 3 : Environments have uuids. #Patch Set 4 : Environments have uuids (regression fix for subs) #
Total messages: 7
|
hazmat
Please take a look.
|
12 years, 12 months ago (2013年01月14日 21:55:41 UTC) #1 | ||||||||||||||||||||||||||||||||
Please take a look.
LGTM. It will be worth adding a note to the hook docs that this env var is present but that can happen later if you want. Given that this will have to be ported to juju-core making a note about its availability is nice. Also I suspect there will be changes in rapi branches to include the env uuid either via a new call or as part of the connect message header.
On 2013年01月15日 14:42:47, bcsaller wrote: > LGTM. It will be worth adding a note to the hook docs that this env var is > present but that can happen later if you want. Given that this will have to be > ported to juju-core making a note about its availability is nice. > > Also I suspect there will be changes in rapi branches to include the env uuid > either via a new call or as part of the connect message header. thanks for the review. docs and rapi are in different branches so need to be tackled separately. i fired off an email to juju-dev re the functionality.
*** Submitted: Environments have uuids. Data collection tools that want to operate on multiple environments need to be unambigiously refererence an identity for the environment. This branch introduces a JUJU_ENV_UUID variable, available in hooks for this purpose. R=bcsaller CC= https://codereview.appspot.com/7092055
Please take a look.
On 2013年01月16日 19:02:23, hazmat wrote: > Please take a look. +1, LGTM
*** Submitted: Environments have uuids (regression fix for subs) Previous environment uuid work caused issues with subordinates, added an additional test and one line fix for. Fixes bugs https://bugs.launchpad.net/juju/+bug/1100245 https://bugs.launchpad.net/juju/+bug/1100348 R=jimbaker CC= https://codereview.appspot.com/7092055